From 5b7774fcaf1498b7c72448fcd0497fcc44efd7cc Mon Sep 17 00:00:00 2001 From: tofunmi Date: Thu, 7 Mar 2024 02:55:30 -0800 Subject: [PATCH] Composition: clarify javadoc to setTransmuxAudio\Video Document that assoicated effects are ignored if these setters are set PiperOrigin-RevId: 613518167 --- .../main/java/androidx/media3/transformer/Composition.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/Composition.java b/libraries/transformer/src/main/java/androidx/media3/transformer/Composition.java index b6fec3a7a6..b3067cb35c 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/Composition.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/Composition.java @@ -173,7 +173,8 @@ public final class Composition { * the audio tracks are transcoded by default. They are all transmuxed if {@code transmuxAudio} * is {@code true}. Transmuxed tracks must be compatible (typically, all the {@link MediaItem} * instances containing the track to transmux are concatenated in a single {@link - * EditedMediaItemSequence} and have the same sample format for that track). + * EditedMediaItemSequence} and have the same sample format for that track). Any transcoding + * effects requested will be ignored. * *

Requesting audio transmuxing and {@linkplain #experimentalSetForceAudioTrack(boolean) * forcing an audio track} are not allowed together because generating silence requires @@ -200,7 +201,8 @@ public final class Composition { * the video tracks are transcoded by default. They are all transmuxed if {@code transmuxVideo} * is {@code true}. Transmuxed tracks must be compatible (typically, all the {@link MediaItem} * instances containing the track to transmux are concatenated in a single {@link - * EditedMediaItemSequence} and have the same sample format for that track). + * EditedMediaItemSequence} and have the same sample format for that track). Any transcoding + * effects requested will be ignored. * * @param transmuxVideo Whether to transmux the video tracks. * @return This builder.