loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix 3 ErrorProneStyle findings:

Browse Source 
* Non-standard parameter comment; prefer `/* paramName= */ arg`
  (see http://go/bugpattern/ParameterComment) (3 times)

This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
* File a bug under go/rosie-bug if there's an issue with how the CL was managed.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.

This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
Anything wrong with the signup? File a bug at go/clrobot-bug.

#codehealth

Tested:
    Local presubmit tests passed.
PiperOrigin-RevId: 472254253
This commit is contained in:
Googler 2022-09-05 12:08:04 +00:00 committed by Marc Baechinger
parent 83485bc509
commit 573ad66f2f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/exoplayer/src/test/java/androidx/media3/exoplayer/audio/MediaCodecAudioRendererTest.java
View File

@ -153,7 +153,7 @@ public class MediaCodecAudioRendererTest {
/* joining= */ false, /* joining= */ false,
/* mayRenderStartOfStream= */ false, /* mayRenderStartOfStream= */ false,
/* startPositionUs= */ 0, /* startPositionUs= */ 0,
/* offsetUs */ 0); /* offsetUs= */ 0);
mediaCodecAudioRenderer.start(); mediaCodecAudioRenderer.start();
mediaCodecAudioRenderer.render(/* positionUs= */ 0, SystemClock.elapsedRealtime() * 1000); mediaCodecAudioRenderer.render(/* positionUs= */ 0, SystemClock.elapsedRealtime() * 1000);
@ -210,7 +210,7 @@ public class MediaCodecAudioRendererTest {
/* joining= */ false, /* joining= */ false,
/* mayRenderStartOfStream= */ false, /* mayRenderStartOfStream= */ false,
/* startPositionUs= */ 0, /* startPositionUs= */ 0,
/* offsetUs */ 0); /* offsetUs= */ 0);
mediaCodecAudioRenderer.start(); mediaCodecAudioRenderer.start();
mediaCodecAudioRenderer.render(/* positionUs= */ 0, SystemClock.elapsedRealtime() * 1000); mediaCodecAudioRenderer.render(/* positionUs= */ 0, SystemClock.elapsedRealtime() * 1000);
@ -284,7 +284,7 @@ public class MediaCodecAudioRendererTest {
/* joining= */ false, /* joining= */ false,
/* mayRenderStartOfStream= */ false, /* mayRenderStartOfStream= */ false,
/* startPositionUs= */ 0, /* startPositionUs= */ 0,
/* offsetUs */ 0); /* offsetUs= */ 0);
exceptionThrowingRenderer.start(); exceptionThrowingRenderer.start();
exceptionThrowingRenderer.render(/* positionUs= */ 0, SystemClock.elapsedRealtime() * 1000); exceptionThrowingRenderer.render(/* positionUs= */ 0, SystemClock.elapsedRealtime() * 1000);