From 4b4904899c2f181d1b28634b40cf075e8b46fa7f Mon Sep 17 00:00:00 2001 From: huangdarwin Date: Thu, 19 Jan 2023 19:46:01 +0000 Subject: [PATCH] HDR: Clarify media3.effect hdrStaticInfo / colorRange support. Clarify that we always output on full range colors, and don't handle hdrStaticInfo input yet. PiperOrigin-RevId: 503224687 --- .../java/androidx/media3/effect/GlEffectsFrameProcessor.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libraries/effect/src/main/java/androidx/media3/effect/GlEffectsFrameProcessor.java b/libraries/effect/src/main/java/androidx/media3/effect/GlEffectsFrameProcessor.java index 39b1df57b3..309d3f44df 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/GlEffectsFrameProcessor.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/GlEffectsFrameProcessor.java @@ -69,6 +69,11 @@ public final class GlEffectsFrameProcessor implements FrameProcessor { * required, and {@link ColorInfo#colorTransfer outputColorInfo.colorTransfer} must be {@link * C#COLOR_TRANSFER_ST2084}. * + *

{@link Effect}s are applied on {@link C#COLOR_RANGE_FULL} colors with {@code null} {@link + * ColorInfo#hdrStaticInfo}. {@code inputColorInfo}'s {@link ColorInfo#hdrStaticInfo} and {@code + * outputColorInfo}'s {@link ColorInfo#colorRange} values are currently ignored, in favor of + * {@code null} and {@link C#COLOR_RANGE_FULL}, respectively. + * *

Pass a {@link MoreExecutors#directExecutor() direct listenerExecutor} if invoking the * {@code listener} on {@link GlEffectsFrameProcessor}'s internal thread is desired. */