loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove zero-byte resource from FileDataSourceContractTest

Browse Source 
This was added due to a misunderstanding - we're more interested in
testing the edge case of trying to read the last zero bytes of a
non-zero-byte resource.

In a future change I want to be able test reading a subrange, so each
TestResource will need to be at least N bytes long.

PiperOrigin-RevId: 347980843
This commit is contained in:
ibaker 2020-12-17 09:41:44 +00:00 committed by Christos Tsilopoulos
parent 8da4eaa377
commit 4849b3e35d
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
library/core/src/test/java/com/google/android/exoplayer2/upstream/FileDataSourceContractTest.java
View File

@ -24,7 +24,6 @@ import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.nio.file.Files; import java.nio.file.Files;
import java.nio.file.Paths; import java.nio.file.Paths;
import okhttp3.internal.Util;
import org.junit.Before; import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.rules.TemporaryFolder; import org.junit.rules.TemporaryFolder;
@ -39,12 +38,10 @@ public class FileDataSourceContractTest extends DataSourceContractTest {
@Rule public final TemporaryFolder tempFolder = new TemporaryFolder(); @Rule public final TemporaryFolder tempFolder = new TemporaryFolder();
private Uri simpleUri; private Uri simpleUri;
private Uri zeroBytesUri;
@Before @Before
public void writeFiles() throws Exception { public void writeFiles() throws Exception {
simpleUri = writeFile(DATA); simpleUri = writeFile(DATA);
zeroBytesUri = writeFile(Util.EMPTY_BYTE_ARRAY);
} }
@Override @Override
@ -54,11 +51,6 @@ public class FileDataSourceContractTest extends DataSourceContractTest {
.setName("simple") .setName("simple")
.setUri(simpleUri) .setUri(simpleUri)
.setExpectedBytes(DATA) .setExpectedBytes(DATA)
.build(),
new TestResource.Builder()
.setName("zero-bytes")
.setUri(zeroBytesUri)
.setExpectedBytes(Util.EMPTY_BYTE_ARRAY)
.build()); .build());
} }