loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mark always passing test as @Ignore.

Browse Source 
Added a TODO inline linking to the created bug to address this.

PiperOrigin-RevId: 554422990
This commit is contained in:
samrobinson 2023-08-07 10:24:51 +00:00 committed by Tianyi Feng
parent aed21e464e
commit 42425334ae
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libraries/transformer/src/test/java/androidx/media3/transformer/MediaItemExportTest.java
View File

@ -90,6 +90,7 @@ import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference; import java.util.concurrent.atomic.AtomicReference;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor; import org.mockito.ArgumentCaptor;
@ -919,6 +920,7 @@ public final class MediaItemExportTest {
} }
@Test @Test
@Ignore("TODO: b/294389961 - Add valid assertion for whether exporter expects decoded/encoded.")
public void start_withAssetLoaderAlwaysDecoding_exporterExpectsDecoded() throws Exception { public void start_withAssetLoaderAlwaysDecoding_exporterExpectsDecoded() throws Exception {
AtomicReference<SampleConsumer> sampleConsumerRef = new AtomicReference<>(); AtomicReference<SampleConsumer> sampleConsumerRef = new AtomicReference<>();
Transformer transformer = Transformer transformer =
@ -931,6 +933,7 @@ public final class MediaItemExportTest {
transformer.start(mediaItem, outputPath); transformer.start(mediaItem, outputPath);
runLooperUntil(transformer.getApplicationLooper(), () -> sampleConsumerRef.get() != null); runLooperUntil(transformer.getApplicationLooper(), () -> sampleConsumerRef.get() != null);
// Can never be false.
assertThat(sampleConsumerRef.get()).isNotInstanceOf(EncodedSampleExporter.class); assertThat(sampleConsumerRef.get()).isNotInstanceOf(EncodedSampleExporter.class);
} }