diff --git a/RELEASENOTES.md b/RELEASENOTES.md index 3b2b5c560f..54aa286c8b 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -28,6 +28,11 @@ Release notes `Subtitle.getEventTime` if a subtitle file contains no cues. * SubRip: Add support for UTF-16 files if they start with a byte order mark. +* UI: + * Fix the deprecated + `PlayerView.setControllerVisibilityListener(PlayerControlView.VisibilityListener)` + to ensure visibility changes are passed to the registered listener + ([#229](https://github.com/androidx/media/issues/229)). * Session: * Add abstract `SimpleBasePlayer` to help implement the `Player` interface for custom players. diff --git a/libraries/ui/src/main/java/androidx/media3/ui/PlayerView.java b/libraries/ui/src/main/java/androidx/media3/ui/PlayerView.java index 6731d040a3..b91d14cb5f 100644 --- a/libraries/ui/src/main/java/androidx/media3/ui/PlayerView.java +++ b/libraries/ui/src/main/java/androidx/media3/ui/PlayerView.java @@ -887,8 +887,8 @@ public class PlayerView extends FrameLayout implements AdViewProvider { /** * Sets the {@link PlayerControlView.VisibilityListener}. * - *
Removes any listener set by {@link - * #setControllerVisibilityListener(PlayerControlView.VisibilityListener)}. + *
If {@code listener} is non-null then any listener set by {@link + * #setControllerVisibilityListener(PlayerControlView.VisibilityListener)} is removed. * * @param listener The listener to be notified about visibility changes, or null to remove the * current listener. @@ -896,14 +896,16 @@ public class PlayerView extends FrameLayout implements AdViewProvider { @SuppressWarnings("deprecation") // Clearing the legacy listener. public void setControllerVisibilityListener(@Nullable ControllerVisibilityListener listener) { this.controllerVisibilityListener = listener; - setControllerVisibilityListener((PlayerControlView.VisibilityListener) null); + if (listener != null) { + setControllerVisibilityListener((PlayerControlView.VisibilityListener) null); + } } /** * Sets the {@link PlayerControlView.VisibilityListener}. * - *
Removes any listener set by {@link - * #setControllerVisibilityListener(ControllerVisibilityListener)}. + *
If {@code listener} is non-null then any listener set by {@link + * #setControllerVisibilityListener(ControllerVisibilityListener)} is removed. * * @deprecated Use {@link #setControllerVisibilityListener(ControllerVisibilityListener)} instead. */ @@ -923,8 +925,8 @@ public class PlayerView extends FrameLayout implements AdViewProvider { this.legacyControllerVisibilityListener = listener; if (listener != null) { controller.addVisibilityListener(listener); + setControllerVisibilityListener((ControllerVisibilityListener) null); } - setControllerVisibilityListener((ControllerVisibilityListener) null); } /**