From 3ed7e561bbf2da49d01e77569a9ade655d75fece Mon Sep 17 00:00:00 2001 From: ibaker Date: Mon, 9 Oct 2023 03:28:12 -0700 Subject: [PATCH] Set `Format.cueReplacementBehavior` in `SubtitleExtractor` This is more correct, though in reality all text-based subtitles handled by `SubtitleExtractor` are implemented with MERGE behavior in media3. PiperOrigin-RevId: 571888573 --- .../java/androidx/media3/extractor/text/SubtitleExtractor.java | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/text/SubtitleExtractor.java b/libraries/extractor/src/main/java/androidx/media3/extractor/text/SubtitleExtractor.java index 8de2e12635..40ef8eac0c 100644 --- a/libraries/extractor/src/main/java/androidx/media3/extractor/text/SubtitleExtractor.java +++ b/libraries/extractor/src/main/java/androidx/media3/extractor/text/SubtitleExtractor.java @@ -111,6 +111,7 @@ public class SubtitleExtractor implements Extractor { .buildUpon() .setSampleMimeType(MimeTypes.APPLICATION_MEDIA3_CUES) .setCodecs(format.sampleMimeType) + .setCueReplacementBehavior(subtitleParser.getCueReplacementBehavior()) .build(); samples = new ArrayList<>(); state = STATE_CREATED;