Merge pull request #248 from lemondoglol:update-segment-size
PiperOrigin-RevId: 507784608 (cherry picked from commit 08342ea9da96240c87e3e7c486eec0b0929138da)
This commit is contained in:
parent
bc9f2be8ab
commit
3dcdfe5d7c
@ -72,8 +72,9 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
||||
}
|
||||
}
|
||||
|
||||
public static final long DEFAULT_MAX_MERGED_SEGMENT_START_TIME_DIFF_MS = 20 * C.MILLIS_PER_SECOND;
|
||||
|
||||
private static final int BUFFER_SIZE_BYTES = 128 * 1024;
|
||||
private static final long MAX_MERGED_SEGMENT_START_TIME_DIFF_US = 20 * C.MICROS_PER_SECOND;
|
||||
|
||||
private final DataSpec manifestDataSpec;
|
||||
private final Parser<M> manifestParser;
|
||||
@ -83,6 +84,7 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
||||
private final CacheKeyFactory cacheKeyFactory;
|
||||
@Nullable private final PriorityTaskManager priorityTaskManager;
|
||||
private final Executor executor;
|
||||
private final long maxMergedSegmentStartTimeDiffUs;
|
||||
|
||||
/**
|
||||
* The currently active runnables.
|
||||
@ -96,6 +98,24 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
||||
|
||||
private volatile boolean isCanceled;
|
||||
|
||||
/**
|
||||
* @deprecated Use {@link SegmentDownloader#SegmentDownloader(MediaItem, Parser,
|
||||
* CacheDataSource.Factory, Executor, long)} instead.
|
||||
*/
|
||||
@Deprecated
|
||||
public SegmentDownloader(
|
||||
MediaItem mediaItem,
|
||||
Parser<M> manifestParser,
|
||||
CacheDataSource.Factory cacheDataSourceFactory,
|
||||
Executor executor) {
|
||||
this(
|
||||
mediaItem,
|
||||
manifestParser,
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
DEFAULT_MAX_MERGED_SEGMENT_START_TIME_DIFF_MS);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param mediaItem The {@link MediaItem} to be downloaded.
|
||||
* @param manifestParser A parser for manifests belonging to the media to be downloaded.
|
||||
@ -104,12 +124,16 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
||||
* @param executor An {@link Executor} used to make requests for the media being downloaded.
|
||||
* Providing an {@link Executor} that uses multiple threads will speed up the download by
|
||||
* allowing parts of it to be executed in parallel.
|
||||
* @param maxMergedSegmentStartTimeDiffMs The maximum difference of the start time of two
|
||||
* segments, up to which the segments (of the same URI) should be merged into a single
|
||||
* download segment, in milliseconds.
|
||||
*/
|
||||
public SegmentDownloader(
|
||||
MediaItem mediaItem,
|
||||
Parser<M> manifestParser,
|
||||
CacheDataSource.Factory cacheDataSourceFactory,
|
||||
Executor executor) {
|
||||
Executor executor,
|
||||
long maxMergedSegmentStartTimeDiffMs) {
|
||||
checkNotNull(mediaItem.localConfiguration);
|
||||
this.manifestDataSpec = getCompressibleDataSpec(mediaItem.localConfiguration.uri);
|
||||
this.manifestParser = manifestParser;
|
||||
@ -120,6 +144,7 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
||||
cacheKeyFactory = cacheDataSourceFactory.getCacheKeyFactory();
|
||||
priorityTaskManager = cacheDataSourceFactory.getUpstreamPriorityTaskManager();
|
||||
activeRunnables = new ArrayList<>();
|
||||
maxMergedSegmentStartTimeDiffUs = Util.msToUs(maxMergedSegmentStartTimeDiffMs);
|
||||
}
|
||||
|
||||
@Override
|
||||
@ -142,7 +167,7 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
||||
// Sort the segments so that we download media in the right order from the start of the
|
||||
// content, and merge segments where possible to minimize the number of server round trips.
|
||||
Collections.sort(segments);
|
||||
mergeSegments(segments, cacheKeyFactory);
|
||||
mergeSegments(segments, cacheKeyFactory, maxMergedSegmentStartTimeDiffUs);
|
||||
|
||||
// Scan the segments, removing any that are fully downloaded.
|
||||
int totalSegments = segments.size();
|
||||
@ -413,7 +438,8 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
||||
}
|
||||
}
|
||||
|
||||
private static void mergeSegments(List<Segment> segments, CacheKeyFactory keyFactory) {
|
||||
private static void mergeSegments(
|
||||
List<Segment> segments, CacheKeyFactory keyFactory, long maxMergedSegmentStartTimeDiffUs) {
|
||||
HashMap<String, Integer> lastIndexByCacheKey = new HashMap<>();
|
||||
int nextOutIndex = 0;
|
||||
for (int i = 0; i < segments.size(); i++) {
|
||||
@ -422,7 +448,7 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
||||
@Nullable Integer lastIndex = lastIndexByCacheKey.get(cacheKey);
|
||||
@Nullable Segment lastSegment = lastIndex == null ? null : segments.get(lastIndex);
|
||||
if (lastSegment == null
|
||||
|| segment.startTimeUs > lastSegment.startTimeUs + MAX_MERGED_SEGMENT_START_TIME_DIFF_US
|
||||
|| segment.startTimeUs > lastSegment.startTimeUs + maxMergedSegmentStartTimeDiffUs
|
||||
|| !canMergeSegments(lastSegment.dataSpec, segment.dataSpec)) {
|
||||
lastIndexByCacheKey.put(cacheKey, nextOutIndex);
|
||||
segments.set(nextOutIndex, segment);
|
||||
|
@ -98,7 +98,30 @@ public final class DashDownloader extends SegmentDownloader<DashManifest> {
|
||||
*/
|
||||
public DashDownloader(
|
||||
MediaItem mediaItem, CacheDataSource.Factory cacheDataSourceFactory, Executor executor) {
|
||||
this(mediaItem, new DashManifestParser(), cacheDataSourceFactory, executor);
|
||||
this(
|
||||
mediaItem,
|
||||
new DashManifestParser(),
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
DEFAULT_MAX_MERGED_SEGMENT_START_TIME_DIFF_MS);
|
||||
}
|
||||
|
||||
/**
|
||||
* @deprecated Use {@link DashDownloader#DashDownloader(MediaItem, Parser,
|
||||
* CacheDataSource.Factory, Executor, long)} instead.
|
||||
*/
|
||||
@Deprecated
|
||||
public DashDownloader(
|
||||
MediaItem mediaItem,
|
||||
Parser<DashManifest> manifestParser,
|
||||
CacheDataSource.Factory cacheDataSourceFactory,
|
||||
Executor executor) {
|
||||
this(
|
||||
mediaItem,
|
||||
manifestParser,
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
DEFAULT_MAX_MERGED_SEGMENT_START_TIME_DIFF_MS);
|
||||
}
|
||||
|
||||
/**
|
||||
@ -111,13 +134,22 @@ public final class DashDownloader extends SegmentDownloader<DashManifest> {
|
||||
* @param executor An {@link Executor} used to make requests for the media being downloaded.
|
||||
* Providing an {@link Executor} that uses multiple threads will speed up the download by
|
||||
* allowing parts of it to be executed in parallel.
|
||||
* @param maxMergedSegmentStartTimeDiffMs The maximum difference of the start time of two
|
||||
* segments, up to which the segments (of the same URI) should be merged into a single
|
||||
* download segment, in milliseconds.
|
||||
*/
|
||||
public DashDownloader(
|
||||
MediaItem mediaItem,
|
||||
Parser<DashManifest> manifestParser,
|
||||
CacheDataSource.Factory cacheDataSourceFactory,
|
||||
Executor executor) {
|
||||
super(mediaItem, manifestParser, cacheDataSourceFactory, executor);
|
||||
Executor executor,
|
||||
long maxMergedSegmentStartTimeDiffMs) {
|
||||
super(
|
||||
mediaItem,
|
||||
manifestParser,
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
maxMergedSegmentStartTimeDiffMs);
|
||||
baseUrlExclusionList = new BaseUrlExclusionList();
|
||||
}
|
||||
|
||||
|
@ -87,7 +87,30 @@ public final class HlsDownloader extends SegmentDownloader<HlsPlaylist> {
|
||||
*/
|
||||
public HlsDownloader(
|
||||
MediaItem mediaItem, CacheDataSource.Factory cacheDataSourceFactory, Executor executor) {
|
||||
this(mediaItem, new HlsPlaylistParser(), cacheDataSourceFactory, executor);
|
||||
this(
|
||||
mediaItem,
|
||||
new HlsPlaylistParser(),
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
DEFAULT_MAX_MERGED_SEGMENT_START_TIME_DIFF_MS);
|
||||
}
|
||||
|
||||
/**
|
||||
* @deprecated Use {@link HlsDownloader#HlsDownloader(MediaItem, Parser, CacheDataSource.Factory,
|
||||
* Executor, long)} instead.
|
||||
*/
|
||||
@Deprecated
|
||||
public HlsDownloader(
|
||||
MediaItem mediaItem,
|
||||
Parser<HlsPlaylist> manifestParser,
|
||||
CacheDataSource.Factory cacheDataSourceFactory,
|
||||
Executor executor) {
|
||||
this(
|
||||
mediaItem,
|
||||
manifestParser,
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
DEFAULT_MAX_MERGED_SEGMENT_START_TIME_DIFF_MS);
|
||||
}
|
||||
|
||||
/**
|
||||
@ -100,13 +123,22 @@ public final class HlsDownloader extends SegmentDownloader<HlsPlaylist> {
|
||||
* @param executor An {@link Executor} used to make requests for the media being downloaded.
|
||||
* Providing an {@link Executor} that uses multiple threads will speed up the download by
|
||||
* allowing parts of it to be executed in parallel.
|
||||
* @param maxMergedSegmentStartTimeDiffMs The maximum difference of the start time of two
|
||||
* segments, up to which the segments (of the same URI) should be merged into a single
|
||||
* download segment, in milliseconds.
|
||||
*/
|
||||
public HlsDownloader(
|
||||
MediaItem mediaItem,
|
||||
Parser<HlsPlaylist> manifestParser,
|
||||
CacheDataSource.Factory cacheDataSourceFactory,
|
||||
Executor executor) {
|
||||
super(mediaItem, manifestParser, cacheDataSourceFactory, executor);
|
||||
Executor executor,
|
||||
long maxMergedSegmentStartTimeDiffMs) {
|
||||
super(
|
||||
mediaItem,
|
||||
manifestParser,
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
maxMergedSegmentStartTimeDiffMs);
|
||||
}
|
||||
|
||||
@Override
|
||||
|
@ -91,7 +91,26 @@ public final class SsDownloader extends SegmentDownloader<SsManifest> {
|
||||
.build(),
|
||||
new SsManifestParser(),
|
||||
cacheDataSourceFactory,
|
||||
executor);
|
||||
executor,
|
||||
DEFAULT_MAX_MERGED_SEGMENT_START_TIME_DIFF_MS);
|
||||
}
|
||||
|
||||
/**
|
||||
* @deprecated Use {@link SsDownloader#SsDownloader(MediaItem, Parser, CacheDataSource.Factory,
|
||||
* Executor, long)} instead.
|
||||
*/
|
||||
@Deprecated
|
||||
public SsDownloader(
|
||||
MediaItem mediaItem,
|
||||
Parser<SsManifest> manifestParser,
|
||||
CacheDataSource.Factory cacheDataSourceFactory,
|
||||
Executor executor) {
|
||||
this(
|
||||
mediaItem,
|
||||
manifestParser,
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
DEFAULT_MAX_MERGED_SEGMENT_START_TIME_DIFF_MS);
|
||||
}
|
||||
|
||||
/**
|
||||
@ -104,13 +123,22 @@ public final class SsDownloader extends SegmentDownloader<SsManifest> {
|
||||
* @param executor An {@link Executor} used to make requests for the media being downloaded.
|
||||
* Providing an {@link Executor} that uses multiple threads will speed up the download by
|
||||
* allowing parts of it to be executed in parallel.
|
||||
* @param maxMergedSegmentStartTimeDiffMs The maximum difference of the start time of two
|
||||
* segments, up to which the segments (of the same URI) should be merged into a single
|
||||
* download segment, in milliseconds.
|
||||
*/
|
||||
public SsDownloader(
|
||||
MediaItem mediaItem,
|
||||
Parser<SsManifest> manifestParser,
|
||||
CacheDataSource.Factory cacheDataSourceFactory,
|
||||
Executor executor) {
|
||||
super(mediaItem, manifestParser, cacheDataSourceFactory, executor);
|
||||
Executor executor,
|
||||
long maxMergedSegmentStartTimeDiffMs) {
|
||||
super(
|
||||
mediaItem,
|
||||
manifestParser,
|
||||
cacheDataSourceFactory,
|
||||
executor,
|
||||
maxMergedSegmentStartTimeDiffMs);
|
||||
}
|
||||
|
||||
@Override
|
||||
|
Loading…
x
Reference in New Issue
Block a user