From 3cf21bd5d505c67318071f1351e29bb80cad0572 Mon Sep 17 00:00:00 2001 From: ibaker Date: Fri, 9 Jun 2023 16:00:01 +0000 Subject: [PATCH] Require the list returned by `SubtitleParser` to be sorted by timestamp This makes it more efficient to consume (e.g. we can binary search through it). PiperOrigin-RevId: 539095673 --- .../java/androidx/media3/extractor/text/SubtitleParser.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/text/SubtitleParser.java b/libraries/extractor/src/main/java/androidx/media3/extractor/text/SubtitleParser.java index 4d384a8726..fba84727a2 100644 --- a/libraries/extractor/src/main/java/androidx/media3/extractor/text/SubtitleParser.java +++ b/libraries/extractor/src/main/java/androidx/media3/extractor/text/SubtitleParser.java @@ -56,8 +56,8 @@ public interface SubtitleParser { * @param offset The index in {@code data} to start reading from (inclusive). * @param length The number of bytes to read from {@code data}. * @return The {@linkplain CueGroup cue groups} parsed from {@code data} (and possibly previous - * provided samples too), or null if there is insufficient data to generate a complete {@link - * CueGroup}. + * provided samples too), sorted in ascending order by {@link CueGroup#presentationTimeUs}. + * Otherwise null if there is insufficient data to generate a complete {@link CueGroup}. */ @Nullable List parse(byte[] data, int offset, int length);