loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove statically initialized SessionResult

Browse Source 
SessionResult stores SystemClock.elapsedRealtime() into
this.completionTimeMs, so a statically initialized instance will have
a meaningless value.

PiperOrigin-RevId: 407865809
This commit is contained in:
ibaker 2021-11-05 18:15:00 +00:00 committed by Ian Baker
parent 429672903f
commit 363c9a98ae
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java
View File

@ -158,8 +158,6 @@ import org.checkerframework.checker.nullness.qual.NonNull;
@SuppressWarnings("FutureReturnValueIgnored") // TODO(b/138091975): Not to ignore if feasible @SuppressWarnings("FutureReturnValueIgnored") // TODO(b/138091975): Not to ignore if feasible
/* package */ class MediaControllerImplBase implements MediaControllerImpl { /* package */ class MediaControllerImplBase implements MediaControllerImpl {
private static final SessionResult RESULT_WHEN_CLOSED = new SessionResult(RESULT_INFO_SKIPPED);
public static final String TAG = "MCImplBase"; public static final String TAG = "MCImplBase";
final MediaController instance; final MediaController instance;
@ -383,7 +381,7 @@ import org.checkerframework.checker.nullness.qual.NonNull;
IMediaSession iSession, RemoteSessionTask task) { IMediaSession iSession, RemoteSessionTask task) {
if (iSession != null) { if (iSession != null) {
SequencedFutureManager.SequencedFuture<SessionResult> result = SequencedFutureManager.SequencedFuture<SessionResult> result =
sequencedFutureManager.createSequencedFuture(RESULT_WHEN_CLOSED); sequencedFutureManager.createSequencedFuture(new SessionResult(RESULT_INFO_SKIPPED));
try { try {
task.run(iSession, result.getSequenceNumber()); task.run(iSession, result.getSequenceNumber());
} catch (RemoteException e) { } catch (RemoteException e) {