From 363c9a98ae43729f82c4c8d26944c1e90e44bf65 Mon Sep 17 00:00:00 2001 From: ibaker Date: Fri, 5 Nov 2021 18:15:00 +0000 Subject: [PATCH] Remove statically initialized SessionResult SessionResult stores SystemClock.elapsedRealtime() into this.completionTimeMs, so a statically initialized instance will have a meaningless value. PiperOrigin-RevId: 407865809 --- .../java/androidx/media3/session/MediaControllerImplBase.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java b/libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java index c3a8794fa3..9bc4a5f147 100644 --- a/libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java +++ b/libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java @@ -158,8 +158,6 @@ import org.checkerframework.checker.nullness.qual.NonNull; @SuppressWarnings("FutureReturnValueIgnored") // TODO(b/138091975): Not to ignore if feasible /* package */ class MediaControllerImplBase implements MediaControllerImpl { - private static final SessionResult RESULT_WHEN_CLOSED = new SessionResult(RESULT_INFO_SKIPPED); - public static final String TAG = "MCImplBase"; final MediaController instance; @@ -383,7 +381,7 @@ import org.checkerframework.checker.nullness.qual.NonNull; IMediaSession iSession, RemoteSessionTask task) { if (iSession != null) { SequencedFutureManager.SequencedFuture result = - sequencedFutureManager.createSequencedFuture(RESULT_WHEN_CLOSED); + sequencedFutureManager.createSequencedFuture(new SessionResult(RESULT_INFO_SKIPPED)); try { task.run(iSession, result.getSequenceNumber()); } catch (RemoteException e) {