From 355ed11a3cd6d90eb02d9f773a546561884324b3 Mon Sep 17 00:00:00 2001 From: olly Date: Thu, 7 Nov 2019 15:19:20 +0000 Subject: [PATCH] Suppress warnings emitted by Checker Framework version 2.11.1 More information: https://docs.google.com/document/d/16tpK6aXqN68PvTyvt4siM-m7f0NXi_8xEeitLDzr8xY/edit?usp=sharing Tested: TAP --sample ran all affected tests and none failed http://test/OCL:278915274:BASE:278884711:1573074344615:a6701677 PiperOrigin-RevId: 279080514 --- .../google/android/exoplayer2/ext/flac/FlacDecoderJni.java | 6 ++++++ .../com/google/android/exoplayer2/ui/DefaultTimeBar.java | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/extensions/flac/src/main/java/com/google/android/exoplayer2/ext/flac/FlacDecoderJni.java b/extensions/flac/src/main/java/com/google/android/exoplayer2/ext/flac/FlacDecoderJni.java index 5e020175e7..60f1d32a79 100644 --- a/extensions/flac/src/main/java/com/google/android/exoplayer2/ext/flac/FlacDecoderJni.java +++ b/extensions/flac/src/main/java/com/google/android/exoplayer2/ext/flac/FlacDecoderJni.java @@ -51,6 +51,12 @@ import java.nio.ByteBuffer; @Nullable private byte[] tempBuffer; private boolean endOfExtractorInput; + // the constructor does not initialize fields: tempBuffer + // call to flacInit() not allowed on the given receiver. + @SuppressWarnings({ + "nullness:initialization.fields.uninitialized", + "nullness:method.invocation.invalid" + }) public FlacDecoderJni() throws FlacDecoderException { if (!FlacLibrary.isAvailable()) { throw new FlacDecoderException("Failed to load decoder native libraries."); diff --git a/library/ui/src/main/java/com/google/android/exoplayer2/ui/DefaultTimeBar.java b/library/ui/src/main/java/com/google/android/exoplayer2/ui/DefaultTimeBar.java index 4e7422b291..1efdeac84d 100644 --- a/library/ui/src/main/java/com/google/android/exoplayer2/ui/DefaultTimeBar.java +++ b/library/ui/src/main/java/com/google/android/exoplayer2/ui/DefaultTimeBar.java @@ -239,7 +239,11 @@ public class DefaultTimeBar extends View implements TimeBar { } // Suppress warnings due to usage of View methods in the constructor. - @SuppressWarnings("nullness:method.invocation.invalid") + // the constructor does not initialize fields: adGroupTimesMs, playedAdGroups + @SuppressWarnings({ + "nullness:method.invocation.invalid", + "nullness:initialization.fields.uninitialized" + }) public DefaultTimeBar( Context context, @Nullable AttributeSet attrs,