loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix transformer, effect, muxer and container API dependencies

Browse Source 
The public APIs of these modules reference symbols in some of their
dependencies, so these should be API dependencies, not implementation:
> An API dependency is one that contains at least one type that is
> exposed in the library binary interface, often referred to as its ABI
> (Application Binary Interface).

https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_recognizing_dependencies

Transformer also uses symbols from `lib-common`, but these are already
an API dep of `lib-exoplayer` so no need to duplicate that here.

PiperOrigin-RevId: 605660621
This commit is contained in:
ibaker 2024-02-09 10:00:18 -08:00 committed by Copybara-Service
parent 73c9753229
commit 338aef4830
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/container/build.gradle
View File

@ -42,7 +42,7 @@ android {
} }
dependencies { dependencies {
implementation project(modulePrefix + 'lib-common') api project(modulePrefix + 'lib-common')
implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
testImplementation 'androidx.test.ext:junit:' + androidxTestJUnitVersion testImplementation 'androidx.test.ext:junit:' + androidxTestJUnitVersion
testImplementation 'com.google.truth:truth:' + truthVersion testImplementation 'com.google.truth:truth:' + truthVersion

2
libraries/effect/build.gradle
View File

@ -42,7 +42,7 @@ android {
dependencies { dependencies {
implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
implementation project(modulePrefix + 'lib-common') api project(modulePrefix + 'lib-common')
implementation project(modulePrefix + 'lib-datasource') implementation project(modulePrefix + 'lib-datasource')
compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion
compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion

2
libraries/muxer/build.gradle
View File

@ -42,7 +42,7 @@ android {
} }
dependencies { dependencies {
implementation project(modulePrefix + 'lib-common') api project(modulePrefix + 'lib-common')
implementation project(modulePrefix + 'lib-container') implementation project(modulePrefix + 'lib-container')
implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion

4
libraries/transformer/build.gradle
View File

@ -45,8 +45,8 @@ dependencies {
implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
implementation project(modulePrefix + 'lib-datasource') implementation project(modulePrefix + 'lib-datasource')
implementation project(modulePrefix + 'lib-container') implementation project(modulePrefix + 'lib-container')
implementation project(modulePrefix + 'lib-exoplayer') api project(modulePrefix + 'lib-exoplayer')
implementation project(modulePrefix + 'lib-effect') api project(modulePrefix + 'lib-effect')
implementation project(modulePrefix + 'lib-muxer') implementation project(modulePrefix + 'lib-muxer')
compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion
compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion