From 338aef48306c69807c638c815656a40cc4f478ed Mon Sep 17 00:00:00 2001 From: ibaker Date: Fri, 9 Feb 2024 10:00:18 -0800 Subject: [PATCH] Fix transformer, effect, muxer and container API dependencies The public APIs of these modules reference symbols in some of their dependencies, so these should be API dependencies, not implementation: > An API dependency is one that contains at least one type that is > exposed in the library binary interface, often referred to as its ABI > (Application Binary Interface). https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_recognizing_dependencies Transformer also uses symbols from `lib-common`, but these are already an API dep of `lib-exoplayer` so no need to duplicate that here. PiperOrigin-RevId: 605660621 --- libraries/container/build.gradle | 2 +- libraries/effect/build.gradle | 2 +- libraries/muxer/build.gradle | 2 +- libraries/transformer/build.gradle | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libraries/container/build.gradle b/libraries/container/build.gradle index d14352e056..a6eb672e1b 100644 --- a/libraries/container/build.gradle +++ b/libraries/container/build.gradle @@ -42,7 +42,7 @@ android { } dependencies { - implementation project(modulePrefix + 'lib-common') + api project(modulePrefix + 'lib-common') implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion testImplementation 'androidx.test.ext:junit:' + androidxTestJUnitVersion testImplementation 'com.google.truth:truth:' + truthVersion diff --git a/libraries/effect/build.gradle b/libraries/effect/build.gradle index a15bda88bb..c9b4bf865d 100644 --- a/libraries/effect/build.gradle +++ b/libraries/effect/build.gradle @@ -42,7 +42,7 @@ android { dependencies { implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion - implementation project(modulePrefix + 'lib-common') + api project(modulePrefix + 'lib-common') implementation project(modulePrefix + 'lib-datasource') compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion diff --git a/libraries/muxer/build.gradle b/libraries/muxer/build.gradle index baeb110776..c81260d4d9 100644 --- a/libraries/muxer/build.gradle +++ b/libraries/muxer/build.gradle @@ -42,7 +42,7 @@ android { } dependencies { - implementation project(modulePrefix + 'lib-common') + api project(modulePrefix + 'lib-common') implementation project(modulePrefix + 'lib-container') implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion diff --git a/libraries/transformer/build.gradle b/libraries/transformer/build.gradle index a02f216248..c8e3ac1a94 100644 --- a/libraries/transformer/build.gradle +++ b/libraries/transformer/build.gradle @@ -45,8 +45,8 @@ dependencies { implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion implementation project(modulePrefix + 'lib-datasource') implementation project(modulePrefix + 'lib-container') - implementation project(modulePrefix + 'lib-exoplayer') - implementation project(modulePrefix + 'lib-effect') + api project(modulePrefix + 'lib-exoplayer') + api project(modulePrefix + 'lib-effect') implementation project(modulePrefix + 'lib-muxer') compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion