From 32b0474d5798692e41b7a51bc599b47c22b0987c Mon Sep 17 00:00:00 2001 From: olly Date: Mon, 14 Oct 2019 13:54:07 +0100 Subject: [PATCH] Clean up playback suppression PiperOrigin-RevId: 274561876 --- .../com/google/android/exoplayer2/Player.java | 18 +++++++++--------- .../android/exoplayer2/SimpleExoPlayer.java | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/Player.java b/library/core/src/main/java/com/google/android/exoplayer2/Player.java index da57e9f900..32e0699933 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/Player.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/Player.java @@ -484,12 +484,15 @@ public interface Player { */ @Documented @Retention(RetentionPolicy.SOURCE) - @IntDef({PLAYBACK_SUPPRESSION_REASON_NONE, PLAYBACK_SUPPRESSION_REASON_AUDIO_FOCUS_LOSS}) + @IntDef({ + PLAYBACK_SUPPRESSION_REASON_NONE, + PLAYBACK_SUPPRESSION_REASON_TRANSIENT_AUDIO_FOCUS_LOSS + }) @interface PlaybackSuppressionReason {} /** Playback is not suppressed. */ int PLAYBACK_SUPPRESSION_REASON_NONE = 0; - /** Playback is suppressed because audio focus is lost or can't be acquired. */ - int PLAYBACK_SUPPRESSION_REASON_AUDIO_FOCUS_LOSS = 1; + /** Playback is suppressed due to transient audio focus loss. */ + int PLAYBACK_SUPPRESSION_REASON_TRANSIENT_AUDIO_FOCUS_LOSS = 1; /** * Repeat modes for playback. One of {@link #REPEAT_MODE_OFF}, {@link #REPEAT_MODE_ONE} or {@link @@ -617,13 +620,10 @@ public interface Player { int getPlaybackState(); /** - * Returns reason why playback is suppressed even if {@link #getPlaybackState()} is {@link - * #STATE_READY} and {@link #getPlayWhenReady()} is {@code true}. + * Returns the reason why playback is suppressed even though {@link #getPlayWhenReady()} is {@code + * true}, or {@link #PLAYBACK_SUPPRESSION_REASON_NONE} if playback is not suppressed. * - *

Note that {@link #PLAYBACK_SUPPRESSION_REASON_NONE} indicates that playback is not - * suppressed. - * - * @return The current {@link PlaybackSuppressionReason}. + * @return The current {@link PlaybackSuppressionReason playback suppression reason}. */ @PlaybackSuppressionReason int getPlaybackSuppressionReason(); diff --git a/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java b/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java index a71d5c0bda..4696e7cc43 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java @@ -1232,7 +1232,7 @@ public class SimpleExoPlayer extends BasePlayer @PlaybackSuppressionReason int playbackSuppressionReason = playWhenReady && playerCommand != AudioFocusManager.PLAYER_COMMAND_PLAY_WHEN_READY - ? Player.PLAYBACK_SUPPRESSION_REASON_AUDIO_FOCUS_LOSS + ? Player.PLAYBACK_SUPPRESSION_REASON_TRANSIENT_AUDIO_FOCUS_LOSS : Player.PLAYBACK_SUPPRESSION_REASON_NONE; player.setPlayWhenReady(playWhenReady, playbackSuppressionReason); }