Removed ExoPlayer specific states from SimpleBasePlayer

PiperOrigin-RevId: 492443147
This commit is contained in:
michaelkatz 2022-12-02 13:14:33 +00:00 committed by Ian Baker
parent 64603cba8d
commit 2fd38e3912
2 changed files with 5 additions and 64 deletions

View File

@ -118,8 +118,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
private DeviceInfo deviceInfo; private DeviceInfo deviceInfo;
private int deviceVolume; private int deviceVolume;
private boolean isDeviceMuted; private boolean isDeviceMuted;
private int audioSessionId;
private boolean skipSilenceEnabled;
private Size surfaceSize; private Size surfaceSize;
private boolean newlyRenderedFirstFrame; private boolean newlyRenderedFirstFrame;
private Metadata timedMetadata; private Metadata timedMetadata;
@ -164,8 +162,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
deviceInfo = DeviceInfo.UNKNOWN; deviceInfo = DeviceInfo.UNKNOWN;
deviceVolume = 0; deviceVolume = 0;
isDeviceMuted = false; isDeviceMuted = false;
audioSessionId = C.AUDIO_SESSION_ID_UNSET;
skipSilenceEnabled = false;
surfaceSize = Size.UNKNOWN; surfaceSize = Size.UNKNOWN;
newlyRenderedFirstFrame = false; newlyRenderedFirstFrame = false;
timedMetadata = new Metadata(/* presentationTimeUs= */ C.TIME_UNSET); timedMetadata = new Metadata(/* presentationTimeUs= */ C.TIME_UNSET);
@ -210,8 +206,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
this.deviceInfo = state.deviceInfo; this.deviceInfo = state.deviceInfo;
this.deviceVolume = state.deviceVolume; this.deviceVolume = state.deviceVolume;
this.isDeviceMuted = state.isDeviceMuted; this.isDeviceMuted = state.isDeviceMuted;
this.audioSessionId = state.audioSessionId;
this.skipSilenceEnabled = state.skipSilenceEnabled;
this.surfaceSize = state.surfaceSize; this.surfaceSize = state.surfaceSize;
this.newlyRenderedFirstFrame = state.newlyRenderedFirstFrame; this.newlyRenderedFirstFrame = state.newlyRenderedFirstFrame;
this.timedMetadata = state.timedMetadata; this.timedMetadata = state.timedMetadata;
@ -497,30 +491,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
return this; return this;
} }
/**
* Sets the audio session id.
*
* @param audioSessionId The audio session id.
* @return This builder.
*/
@CanIgnoreReturnValue
public Builder setAudioSessionId(int audioSessionId) {
this.audioSessionId = audioSessionId;
return this;
}
/**
* Sets whether skipping silences in the audio stream is enabled.
*
* @param skipSilenceEnabled Whether skipping silences in the audio stream is enabled.
* @return This builder.
*/
@CanIgnoreReturnValue
public Builder setSkipSilenceEnabled(boolean skipSilenceEnabled) {
this.skipSilenceEnabled = skipSilenceEnabled;
return this;
}
/** /**
* Sets the size of the surface onto which the video is being rendered. * Sets the size of the surface onto which the video is being rendered.
* *
@ -851,10 +821,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
public final int deviceVolume; public final int deviceVolume;
/** Whether the device is muted. */ /** Whether the device is muted. */
public final boolean isDeviceMuted; public final boolean isDeviceMuted;
/** The audio session id. */
public final int audioSessionId;
/** Whether skipping silences in the audio stream is enabled. */
public final boolean skipSilenceEnabled;
/** The size of the surface onto which the video is being rendered. */ /** The size of the surface onto which the video is being rendered. */
public final Size surfaceSize; public final Size surfaceSize;
/** /**
@ -995,8 +961,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
this.deviceInfo = builder.deviceInfo; this.deviceInfo = builder.deviceInfo;
this.deviceVolume = builder.deviceVolume; this.deviceVolume = builder.deviceVolume;
this.isDeviceMuted = builder.isDeviceMuted; this.isDeviceMuted = builder.isDeviceMuted;
this.audioSessionId = builder.audioSessionId;
this.skipSilenceEnabled = builder.skipSilenceEnabled;
this.surfaceSize = builder.surfaceSize; this.surfaceSize = builder.surfaceSize;
this.newlyRenderedFirstFrame = builder.newlyRenderedFirstFrame; this.newlyRenderedFirstFrame = builder.newlyRenderedFirstFrame;
this.timedMetadata = builder.timedMetadata; this.timedMetadata = builder.timedMetadata;
@ -1052,8 +1016,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
&& deviceInfo.equals(state.deviceInfo) && deviceInfo.equals(state.deviceInfo)
&& deviceVolume == state.deviceVolume && deviceVolume == state.deviceVolume
&& isDeviceMuted == state.isDeviceMuted && isDeviceMuted == state.isDeviceMuted
&& audioSessionId == state.audioSessionId
&& skipSilenceEnabled == state.skipSilenceEnabled
&& surfaceSize.equals(state.surfaceSize) && surfaceSize.equals(state.surfaceSize)
&& newlyRenderedFirstFrame == state.newlyRenderedFirstFrame && newlyRenderedFirstFrame == state.newlyRenderedFirstFrame
&& timedMetadata.equals(state.timedMetadata) && timedMetadata.equals(state.timedMetadata)
@ -1098,8 +1060,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
result = 31 * result + deviceInfo.hashCode(); result = 31 * result + deviceInfo.hashCode();
result = 31 * result + deviceVolume; result = 31 * result + deviceVolume;
result = 31 * result + (isDeviceMuted ? 1 : 0); result = 31 * result + (isDeviceMuted ? 1 : 0);
result = 31 * result + audioSessionId;
result = 31 * result + (skipSilenceEnabled ? 1 : 0);
result = 31 * result + surfaceSize.hashCode(); result = 31 * result + surfaceSize.hashCode();
result = 31 * result + (newlyRenderedFirstFrame ? 1 : 0); result = 31 * result + (newlyRenderedFirstFrame ? 1 : 0);
result = 31 * result + timedMetadata.hashCode(); result = 31 * result + timedMetadata.hashCode();
@ -3006,11 +2966,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
Player.EVENT_PLAYBACK_PARAMETERS_CHANGED, Player.EVENT_PLAYBACK_PARAMETERS_CHANGED,
listener -> listener.onPlaybackParametersChanged(newState.playbackParameters)); listener -> listener.onPlaybackParametersChanged(newState.playbackParameters));
} }
if (previousState.skipSilenceEnabled != newState.skipSilenceEnabled) {
listeners.queueEvent(
Player.EVENT_SKIP_SILENCE_ENABLED_CHANGED,
listener -> listener.onSkipSilenceEnabledChanged(newState.skipSilenceEnabled));
}
if (previousState.repeatMode != newState.repeatMode) { if (previousState.repeatMode != newState.repeatMode) {
listeners.queueEvent( listeners.queueEvent(
Player.EVENT_REPEAT_MODE_CHANGED, Player.EVENT_REPEAT_MODE_CHANGED,
@ -3057,11 +3012,6 @@ public abstract class SimpleBasePlayer extends BasePlayer {
Player.EVENT_PLAYLIST_METADATA_CHANGED, Player.EVENT_PLAYLIST_METADATA_CHANGED,
listener -> listener.onPlaylistMetadataChanged(newState.playlistMetadata)); listener -> listener.onPlaylistMetadataChanged(newState.playlistMetadata));
} }
if (previousState.audioSessionId != newState.audioSessionId) {
listeners.queueEvent(
Player.EVENT_AUDIO_SESSION_ID,
listener -> listener.onAudioSessionIdChanged(newState.audioSessionId));
}
if (newState.newlyRenderedFirstFrame) { if (newState.newlyRenderedFirstFrame) {
listeners.queueEvent(Player.EVENT_RENDERED_FIRST_FRAME, Listener::onRenderedFirstFrame); listeners.queueEvent(Player.EVENT_RENDERED_FIRST_FRAME, Listener::onRenderedFirstFrame);
} }

View File

@ -107,8 +107,6 @@ public class SimpleBasePlayerTest {
new DeviceInfo( new DeviceInfo(
DeviceInfo.PLAYBACK_TYPE_LOCAL, /* minVolume= */ 3, /* maxVolume= */ 7)) DeviceInfo.PLAYBACK_TYPE_LOCAL, /* minVolume= */ 3, /* maxVolume= */ 7))
.setIsDeviceMuted(true) .setIsDeviceMuted(true)
.setAudioSessionId(78)
.setSkipSilenceEnabled(true)
.setSurfaceSize(new Size(480, 360)) .setSurfaceSize(new Size(480, 360))
.setNewlyRenderedFirstFrame(true) .setNewlyRenderedFirstFrame(true)
.setTimedMetadata(new Metadata()) .setTimedMetadata(new Metadata())
@ -269,8 +267,6 @@ public class SimpleBasePlayerTest {
.setDeviceInfo(deviceInfo) .setDeviceInfo(deviceInfo)
.setDeviceVolume(5) .setDeviceVolume(5)
.setIsDeviceMuted(true) .setIsDeviceMuted(true)
.setAudioSessionId(78)
.setSkipSilenceEnabled(true)
.setSurfaceSize(surfaceSize) .setSurfaceSize(surfaceSize)
.setNewlyRenderedFirstFrame(true) .setNewlyRenderedFirstFrame(true)
.setTimedMetadata(timedMetadata) .setTimedMetadata(timedMetadata)
@ -311,8 +307,6 @@ public class SimpleBasePlayerTest {
assertThat(state.deviceInfo).isEqualTo(deviceInfo); assertThat(state.deviceInfo).isEqualTo(deviceInfo);
assertThat(state.deviceVolume).isEqualTo(5); assertThat(state.deviceVolume).isEqualTo(5);
assertThat(state.isDeviceMuted).isTrue(); assertThat(state.isDeviceMuted).isTrue();
assertThat(state.audioSessionId).isEqualTo(78);
assertThat(state.skipSilenceEnabled).isTrue();
assertThat(state.surfaceSize).isEqualTo(surfaceSize); assertThat(state.surfaceSize).isEqualTo(surfaceSize);
assertThat(state.newlyRenderedFirstFrame).isTrue(); assertThat(state.newlyRenderedFirstFrame).isTrue();
assertThat(state.timedMetadata).isEqualTo(timedMetadata); assertThat(state.timedMetadata).isEqualTo(timedMetadata);
@ -865,8 +859,6 @@ public class SimpleBasePlayerTest {
.setDeviceInfo(deviceInfo) .setDeviceInfo(deviceInfo)
.setDeviceVolume(5) .setDeviceVolume(5)
.setIsDeviceMuted(true) .setIsDeviceMuted(true)
.setAudioSessionId(78)
.setSkipSilenceEnabled(true)
.setSurfaceSize(surfaceSize) .setSurfaceSize(surfaceSize)
.setPlaylist(playlist) .setPlaylist(playlist)
.setPlaylistMetadata(playlistMetadata) .setPlaylistMetadata(playlistMetadata)
@ -1160,8 +1152,6 @@ public class SimpleBasePlayerTest {
.setDeviceInfo(deviceInfo) .setDeviceInfo(deviceInfo)
.setDeviceVolume(5) .setDeviceVolume(5)
.setIsDeviceMuted(true) .setIsDeviceMuted(true)
.setAudioSessionId(78)
.setSkipSilenceEnabled(true)
.setSurfaceSize(surfaceSize) .setSurfaceSize(surfaceSize)
.setNewlyRenderedFirstFrame(true) .setNewlyRenderedFirstFrame(true)
.setTimedMetadata(timedMetadata) .setTimedMetadata(timedMetadata)
@ -1227,11 +1217,9 @@ public class SimpleBasePlayerTest {
verify(listener).onMediaMetadataChanged(mediaMetadata); verify(listener).onMediaMetadataChanged(mediaMetadata);
verify(listener).onTracksChanged(tracks); verify(listener).onTracksChanged(tracks);
verify(listener).onPlaylistMetadataChanged(playlistMetadata); verify(listener).onPlaylistMetadataChanged(playlistMetadata);
verify(listener).onAudioSessionIdChanged(78);
verify(listener).onRenderedFirstFrame(); verify(listener).onRenderedFirstFrame();
verify(listener).onMetadata(timedMetadata); verify(listener).onMetadata(timedMetadata);
verify(listener).onSurfaceSizeChanged(surfaceSize.getWidth(), surfaceSize.getHeight()); verify(listener).onSurfaceSizeChanged(surfaceSize.getWidth(), surfaceSize.getHeight());
verify(listener).onSkipSilenceEnabledChanged(true);
verify(listener).onPositionDiscontinuity(Player.DISCONTINUITY_REASON_SEEK); verify(listener).onPositionDiscontinuity(Player.DISCONTINUITY_REASON_SEEK);
verify(listener) verify(listener)
.onPositionDiscontinuity( .onPositionDiscontinuity(
@ -1284,9 +1272,7 @@ public class SimpleBasePlayerTest {
Player.EVENT_MAX_SEEK_TO_PREVIOUS_POSITION_CHANGED, Player.EVENT_MAX_SEEK_TO_PREVIOUS_POSITION_CHANGED,
Player.EVENT_TRACK_SELECTION_PARAMETERS_CHANGED, Player.EVENT_TRACK_SELECTION_PARAMETERS_CHANGED,
Player.EVENT_AUDIO_ATTRIBUTES_CHANGED, Player.EVENT_AUDIO_ATTRIBUTES_CHANGED,
Player.EVENT_AUDIO_SESSION_ID,
Player.EVENT_VOLUME_CHANGED, Player.EVENT_VOLUME_CHANGED,
Player.EVENT_SKIP_SILENCE_ENABLED_CHANGED,
Player.EVENT_SURFACE_SIZE_CHANGED, Player.EVENT_SURFACE_SIZE_CHANGED,
Player.EVENT_VIDEO_SIZE_CHANGED, Player.EVENT_VIDEO_SIZE_CHANGED,
Player.EVENT_RENDERED_FIRST_FRAME, Player.EVENT_RENDERED_FIRST_FRAME,
@ -1301,6 +1287,11 @@ public class SimpleBasePlayerTest {
if (method.getName().equals("onSeekProcessed")) { if (method.getName().equals("onSeekProcessed")) {
continue; continue;
} }
if (method.getName().equals("onAudioSessionIdChanged")
|| method.getName().equals("onSkipSilenceEnabledChanged")) {
// Skip listeners for ExoPlayer-specific states
continue;
}
method.invoke(verify(listener), getAnyArguments(method)); method.invoke(verify(listener), getAnyArguments(method));
} }
} }