From 2bb719fd545c39106c2fea94e9cae4351fa6544d Mon Sep 17 00:00:00 2001 From: tonihei Date: Tue, 9 Jul 2024 01:15:13 -0700 Subject: [PATCH] Remove obsolete TODO The idea was to not even write any samples to SampleQueues as they are not needed during the metadata extraction process. However, this is not easily possible as long as we use our existing Extractors and MediaSource/Periods for loading given how deeply ingrained the extraction of samples is in these classes. For most common formats like MP4, no samples will be extracted anyway as they can finish the prepare step without reading any samples. PiperOrigin-RevId: 650529371 --- .../main/java/androidx/media3/exoplayer/MetadataRetriever.java | 1 - 1 file changed, 1 deletion(-) diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/MetadataRetriever.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/MetadataRetriever.java index 221a8003fd..3ced0067f7 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/MetadataRetriever.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/MetadataRetriever.java @@ -43,7 +43,6 @@ import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.SettableFuture; import org.checkerframework.checker.nullness.qual.MonotonicNonNull; -// TODO(internal b/161127201): discard samples written to the sample queue. /** Retrieves the static metadata of {@link MediaItem MediaItems}. */ @UnstableApi public final class MetadataRetriever {