From 253fcb1fd1dc52067ab2193cc58ea976bd215707 Mon Sep 17 00:00:00 2001 From: ibaker Date: Mon, 10 Jun 2024 04:10:21 -0700 Subject: [PATCH] Clarify docs on `ExoPlayer.setVideoEffects()` re calling `prepare()` The previous wording suggested that `setVideoEffects()` may **only** be called before `prepare()`, i.e. the effect cannot be changed during playback. The intent is instead that `setVideoEffects()` must be called once before playback in order to configure the effects pipeline, but the effect can then be changed during playback by further calls to `setVideoEffects()`. Issue: androidx/media#1393 PiperOrigin-RevId: 641853629 --- .../src/main/java/androidx/media3/exoplayer/ExoPlayer.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java index e9fab67679..155d708cae 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java @@ -1691,7 +1691,9 @@ public interface ExoPlayer extends Player { *
  • This feature does not work with {@linkplain Effect effects} that update the frame * timestamps. *
  • This feature does not work with DRM-protected content. - *
  • This method should be called before calling {@link #prepare()}. + *
  • This method must be called at least once before calling {@link #prepare()} (in order to + * set up the effects pipeline). The effects can be changed during playback by subsequent + * calls to this method after {@link #prepare()}. * * * @param videoEffects The {@link List} of {@linkplain Effect video effects} to apply.