loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix some mal formatted TODOs

Browse Source 
PiperOrigin-RevId: 550507208
This commit is contained in:
claincly 2023-07-24 11:44:09 +01:00 committed by Rohit Singh
parent f4ad26451f
commit 22d30b3d74
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/common/src/main/java/androidx/media3/common/GlObjectsProvider.java
View File

@ -25,7 +25,7 @@ import androidx.annotation.RequiresApi;
import androidx.media3.common.util.GlUtil.GlException;
import androidx.media3.common.util.UnstableApi;
// TODO(271433904): Expand this class to cover more methods in GlUtil.
// TODO(b/271433904): Expand this class to cover more methods in GlUtil.
/** Provider to customize the creation and maintenance of GL objects. */
@UnstableApi
public interface GlObjectsProvider {

4
libraries/common/src/main/java/androidx/media3/common/VideoFrameProcessor.java
View File

@ -72,7 +72,7 @@ public interface VideoFrameProcessor {
/** A factory for {@link VideoFrameProcessor} instances. */
interface Factory {
// TODO(271433904): Turn parameters with default values into setters.
// TODO(b/271433904): Turn parameters with default values into setters.
/**
* Creates a new {@link VideoFrameProcessor} instance.
*
@ -208,7 +208,7 @@ public interface VideoFrameProcessor {
* @param inputType The {@link InputType} of the new input stream.
* @param effects The list of {@link Effect effects} to apply to the new input stream.
*/
// TODO(b/286032822) Merge this and setInputFrameInfo.
// TODO(b/286032822): Merge this and setInputFrameInfo.
void registerInputStream(@InputType int inputType, List<Effect> effects);
/**

4
libraries/common/src/main/java/androidx/media3/common/util/GlUtil.java
View File

@ -303,7 +303,7 @@ public final class GlUtil {
// color output, and GL windowAttributes overrides encoder settings.
windowAttributes = EGL_WINDOW_SURFACE_ATTRIBUTES_NONE;
} else {
// TODO(b/262259999) HDR10 PQ content looks dark on the screen.
// TODO(b/262259999): HDR10 PQ content looks dark on the screen.
windowAttributes = EGL_WINDOW_SURFACE_ATTRIBUTES_BT2020_PQ;
}
} else if (colorTransfer == C.COLOR_TRANSFER_HLG) {
@ -579,7 +579,7 @@ public final class GlUtil {
*/
public static int createTexture(int width, int height, boolean useHighPrecisionColorComponents)
throws GlException {
// TODO(227624622): Implement a pixel test that confirms 16f has less posterization.
// TODO(b/227624622): Implement a pixel test that confirms 16f has less posterization.
if (useHighPrecisionColorComponents) {
checkState(Util.SDK_INT >= 18, "GLES30 extensions are not supported below API 18.");
return createTexture(width, height, GLES30.GL_RGBA16F, GLES30.GL_HALF_FLOAT);

2
libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/analysis/SsimMapperTest.java
View File

@ -119,7 +119,7 @@ public class SsimMapperTest {
List<Object[]> parameterList = new ArrayList<>();
for (String file : INPUT_FILES) {
parameterList.add(new Object[] {file, MimeTypes.VIDEO_H264});
// TODO(210593256): Test pre 24 once in-app muxing implemented.
// TODO(b/210593256): Test pre 24 once in-app muxing implemented.
if (Util.SDK_INT >= 24) {
parameterList.add(new Object[] {file, MimeTypes.VIDEO_H265});
}