From 1f47fa832c6228a5545d8a15c9c09fe76c17dfc5 Mon Sep 17 00:00:00 2001 From: claincly Date: Fri, 1 Jul 2022 11:06:12 +0000 Subject: [PATCH] Round the frame rate in MediaFormat Although MediaCodec claims supporting float frame rate, encoder init failed on API21 Nexus 5. Since it's just a performance hint to the codec, it's OK to generalize it to other API versions. PiperOrigin-RevId: 458434650 --- .../androidx/media3/transformer/DefaultEncoderFactory.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java b/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java index fda367d6f0..c3048f4368 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java @@ -23,6 +23,7 @@ import static androidx.media3.common.util.Assertions.checkStateNotNull; import static androidx.media3.common.util.Util.SDK_INT; import static java.lang.Math.abs; import static java.lang.Math.floor; +import static java.lang.Math.round; import android.content.Context; import android.media.MediaCodecInfo; @@ -231,7 +232,7 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory { String mimeType = checkNotNull(format.sampleMimeType); MediaFormat mediaFormat = MediaFormat.createVideoFormat(mimeType, format.width, format.height); - mediaFormat.setFloat(MediaFormat.KEY_FRAME_RATE, format.frameRate); + mediaFormat.setInteger(MediaFormat.KEY_FRAME_RATE, round(format.frameRate)); mediaFormat.setInteger( MediaFormat.KEY_BIT_RATE, supportedVideoEncoderSettings.bitrate != VideoEncoderSettings.NO_VALUE