loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update max overlays in one OverlayTextureProcessor

Browse Source 
Tested adding 3, 15,16 different overlays in a single OverlayTextureProcessor. The program errored out when 16 overlays were added.

PiperOrigin-RevId: 504810157
This commit is contained in:
tofunmi 2023-01-26 12:52:16 +00:00 committed by christosts
parent a5d43b2194
commit 1a416b17b5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libraries/effect/src/main/java/androidx/media3/effect/OverlayTextureProcessor.java
View File

@ -56,11 +56,11 @@ import com.google.common.collect.ImmutableList;
throws FrameProcessingException {
super(useHdr);
checkArgument(!useHdr, "OverlayTextureProcessor does not support HDR colors yet.");
// TODO: If the limit on the number of overlays ever becomes and issue, investigate expanding it
// in relation to common device limits.
// The maximum number of samplers allowed in a single GL program is 16.
// We use one for every overlay and one for the video.
checkArgument(
overlays.size() <= 8,
"OverlayTextureProcessor does not more than 8 overlays in the same processor yet.");
overlays.size() <= 15,
"OverlayTextureProcessor does not support more than 15 overlays in the same processor.");
this.overlays = overlays;
aspectRatioMatrix = GlUtil.create4x4IdentityMatrix();
overlayMatrix = GlUtil.create4x4IdentityMatrix();