loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix recreation of DefaultShaderProgram in FinalWrapper

Browse Source 
`outputSurfaceInfoChanged` is not reset when `defaultShaderProgram` is null.
That is, on the first time `ensureConfigured()` is called with output size
changed, `outputSurfaceInfoChanged` is not set to false after creating the
`defaultShaderProgram`, and `defaultShaderProgram` will be created again on the
second time `ensureConfigured()` is called.

PiperOrigin-RevId: 537870404
This commit is contained in:
claincly 2023-06-05 14:32:57 +00:00 committed by Tofunmi Adigun-Hameed
parent 4306e0bb82
commit 133943a635
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libraries/effect/src/main/java/androidx/media3/effect/FinalShaderProgramWrapper.java
View File

@ -461,14 +461,15 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
defaultShaderProgram = null; defaultShaderProgram = null;
outputSurfaceInfoChanged = false; outputSurfaceInfoChanged = false;
} }
if (defaultShaderProgram == null) { if (defaultShaderProgram == null) {
defaultShaderProgram = defaultShaderProgram =
createDefaultShaderProgram( createDefaultShaderProgram(
outputSurfaceInfo == null ? 0 : outputSurfaceInfo.orientationDegrees, outputSurfaceInfo == null ? 0 : outputSurfaceInfo.orientationDegrees,
outputWidth, outputWidth,
outputHeight); outputHeight);
outputSurfaceInfoChanged = false;
} }
return true; return true;
} }