loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tracing under offload.

Browse Source 
Currently doSomeWork is never closed and so tracing is deceiving.

See https://screenshot.googleplex.com/eZDzn5APpBNnhe5

PiperOrigin-RevId: 474755816
(cherry picked from commit 06230f19c7e32728c52f71eff4243f52f534b9e1)
This commit is contained in:
yschimke 2022-09-16 08:26:54 +00:00 committed by microkatz
parent 40cec25d20
commit 12e843ed60
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
RELEASENOTES.md
View File

@ -13,6 +13,7 @@
([#10458](https://github.com/google/ExoPlayer/issues/10458)). ([#10458](https://github.com/google/ExoPlayer/issues/10458)).
* Discard back buffer before playback gets stuck due to insufficient * Discard back buffer before playback gets stuck due to insufficient
available memory. available memory.
* Close the Tracing "doSomeWork" block when offload is enabled.
* Downloads: * Downloads:
* Fix potential infinite loop in `ProgressiveDownloader` caused by * Fix potential infinite loop in `ProgressiveDownloader` caused by
simultaneous download and playback with the same `PriorityTaskManager` simultaneous download and playback with the same `PriorityTaskManager`

1
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayerImplInternal.java
View File

@ -1092,7 +1092,6 @@ import java.util.concurrent.atomic.AtomicBoolean;
if (sleepingForOffload || playbackInfo.playbackState == Player.STATE_ENDED) { if (sleepingForOffload || playbackInfo.playbackState == Player.STATE_ENDED) {
// No need to schedule next work. // No need to schedule next work.
return;
} else if (isPlaying || playbackInfo.playbackState == Player.STATE_BUFFERING) { } else if (isPlaying || playbackInfo.playbackState == Player.STATE_BUFFERING) {
// We are actively playing or waiting for data to be ready. Schedule next work quickly. // We are actively playing or waiting for data to be ready. Schedule next work quickly.
scheduleNextWork(operationStartTimeMs, ACTIVE_INTERVAL_MS); scheduleNextWork(operationStartTimeMs, ACTIVE_INTERVAL_MS);