loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use removeKey method instead of setting null for KEY_CODECS_STRING

Browse Source 
Setting a `null` value doesn't remove the key as expected per the `MediaFormat` API documentation, using the `removeKey` method instead which is only available starting API level 29.

PiperOrigin-RevId: 646462402
This commit is contained in:
rohks 2024-06-25 06:54:16 -07:00 committed by Copybara-Service
parent 5fcc7433a1
commit 12c42585d2
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/MediaExtractorCompat.java
View File

@ -647,7 +647,9 @@ public final class MediaExtractorCompat {
MediaFormat mediaFormatResult = MediaFormatUtil.createMediaFormatFromFormat(result);
scratchFormatHolder.clear();
if (compatibilityTrackMimeType != null) {
mediaFormatResult.setString(MediaFormat.KEY_CODECS_STRING, null);
if (Util.SDK_INT >= 29) {
mediaFormatResult.removeKey(MediaFormat.KEY_CODECS_STRING);
}
mediaFormatResult.setString(MediaFormat.KEY_MIME, compatibilityTrackMimeType);
}
return mediaFormatResult;