Add Nullable to message payload.
Not having this annotation may cause Kotlin implementations to fail. Issue:#4802 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212980643
This commit is contained in:
parent
6f6f381beb
commit
1284f9ea4d
@ -640,7 +640,7 @@ public class LibvpxVideoRenderer extends BaseRenderer {
|
|||||||
// PlayerMessage.Target implementation.
|
// PlayerMessage.Target implementation.
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(int messageType, Object message) throws ExoPlaybackException {
|
public void handleMessage(int messageType, @Nullable Object message) throws ExoPlaybackException {
|
||||||
if (messageType == C.MSG_SET_SURFACE) {
|
if (messageType == C.MSG_SET_SURFACE) {
|
||||||
setOutput((Surface) message, null);
|
setOutput((Surface) message, null);
|
||||||
} else if (messageType == MSG_SET_OUTPUT_BUFFER_RENDERER) {
|
} else if (messageType == MSG_SET_OUTPUT_BUFFER_RENDERER) {
|
||||||
|
@ -163,7 +163,7 @@ public abstract class BaseRenderer implements Renderer, RendererCapabilities {
|
|||||||
// PlayerMessage.Target implementation.
|
// PlayerMessage.Target implementation.
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(int what, Object object) throws ExoPlaybackException {
|
public void handleMessage(int what, @Nullable Object object) throws ExoPlaybackException {
|
||||||
// Do nothing.
|
// Do nothing.
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -15,6 +15,7 @@
|
|||||||
*/
|
*/
|
||||||
package com.google.android.exoplayer2;
|
package com.google.android.exoplayer2;
|
||||||
|
|
||||||
|
import android.support.annotation.Nullable;
|
||||||
import com.google.android.exoplayer2.source.SampleStream;
|
import com.google.android.exoplayer2.source.SampleStream;
|
||||||
import com.google.android.exoplayer2.util.Assertions;
|
import com.google.android.exoplayer2.util.Assertions;
|
||||||
import com.google.android.exoplayer2.util.MediaClock;
|
import com.google.android.exoplayer2.util.MediaClock;
|
||||||
@ -182,7 +183,7 @@ public abstract class NoSampleRenderer implements Renderer, RendererCapabilities
|
|||||||
// PlayerMessage.Target implementation.
|
// PlayerMessage.Target implementation.
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(int what, Object object) throws ExoPlaybackException {
|
public void handleMessage(int what, @Nullable Object object) throws ExoPlaybackException {
|
||||||
// Do nothing.
|
// Do nothing.
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -36,7 +36,7 @@ public final class PlayerMessage {
|
|||||||
* @throws ExoPlaybackException If an error occurred whilst handling the message. Should only be
|
* @throws ExoPlaybackException If an error occurred whilst handling the message. Should only be
|
||||||
* thrown by targets that handle messages on the playback thread.
|
* thrown by targets that handle messages on the playback thread.
|
||||||
*/
|
*/
|
||||||
void handleMessage(int messageType, Object payload) throws ExoPlaybackException;
|
void handleMessage(int messageType, @Nullable Object payload) throws ExoPlaybackException;
|
||||||
}
|
}
|
||||||
|
|
||||||
/** A sender for messages. */
|
/** A sender for messages. */
|
||||||
@ -55,7 +55,7 @@ public final class PlayerMessage {
|
|||||||
private final Timeline timeline;
|
private final Timeline timeline;
|
||||||
|
|
||||||
private int type;
|
private int type;
|
||||||
private Object payload;
|
private @Nullable Object payload;
|
||||||
private Handler handler;
|
private Handler handler;
|
||||||
private int windowIndex;
|
private int windowIndex;
|
||||||
private long positionMs;
|
private long positionMs;
|
||||||
@ -134,7 +134,7 @@ public final class PlayerMessage {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/** Returns the message payload forwarded to {@link Target#handleMessage(int, Object)}. */
|
/** Returns the message payload forwarded to {@link Target#handleMessage(int, Object)}. */
|
||||||
public Object getPayload() {
|
public @Nullable Object getPayload() {
|
||||||
return payload;
|
return payload;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -645,7 +645,7 @@ public class MediaCodecAudioRenderer extends MediaCodecRenderer implements Media
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(int messageType, Object message) throws ExoPlaybackException {
|
public void handleMessage(int messageType, @Nullable Object message) throws ExoPlaybackException {
|
||||||
switch (messageType) {
|
switch (messageType) {
|
||||||
case C.MSG_SET_VOLUME:
|
case C.MSG_SET_VOLUME:
|
||||||
audioSink.setVolume((Float) message);
|
audioSink.setVolume((Float) message);
|
||||||
|
@ -584,7 +584,7 @@ public abstract class SimpleDecoderAudioRenderer extends BaseRenderer implements
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(int messageType, Object message) throws ExoPlaybackException {
|
public void handleMessage(int messageType, @Nullable Object message) throws ExoPlaybackException {
|
||||||
switch (messageType) {
|
switch (messageType) {
|
||||||
case C.MSG_SET_VOLUME:
|
case C.MSG_SET_VOLUME:
|
||||||
audioSink.setVolume((Float) message);
|
audioSink.setVolume((Float) message);
|
||||||
|
@ -543,7 +543,8 @@ public class ConcatenatingMediaSource extends CompositeMediaSource<MediaSourceHo
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
@SuppressWarnings("unchecked")
|
@SuppressWarnings("unchecked")
|
||||||
public final void handleMessage(int messageType, Object message) throws ExoPlaybackException {
|
public final void handleMessage(int messageType, @Nullable Object message)
|
||||||
|
throws ExoPlaybackException {
|
||||||
if (player == null) {
|
if (player == null) {
|
||||||
// Stale event.
|
// Stale event.
|
||||||
return;
|
return;
|
||||||
@ -551,13 +552,13 @@ public class ConcatenatingMediaSource extends CompositeMediaSource<MediaSourceHo
|
|||||||
switch (messageType) {
|
switch (messageType) {
|
||||||
case MSG_ADD:
|
case MSG_ADD:
|
||||||
MessageData<Collection<MediaSourceHolder>> addMessage =
|
MessageData<Collection<MediaSourceHolder>> addMessage =
|
||||||
(MessageData<Collection<MediaSourceHolder>>) message;
|
(MessageData<Collection<MediaSourceHolder>>) Util.castNonNull(message);
|
||||||
shuffleOrder = shuffleOrder.cloneAndInsert(addMessage.index, addMessage.customData.size());
|
shuffleOrder = shuffleOrder.cloneAndInsert(addMessage.index, addMessage.customData.size());
|
||||||
addMediaSourcesInternal(addMessage.index, addMessage.customData);
|
addMediaSourcesInternal(addMessage.index, addMessage.customData);
|
||||||
scheduleListenerNotification(addMessage.actionOnCompletion);
|
scheduleListenerNotification(addMessage.actionOnCompletion);
|
||||||
break;
|
break;
|
||||||
case MSG_REMOVE:
|
case MSG_REMOVE:
|
||||||
MessageData<Integer> removeMessage = (MessageData<Integer>) message;
|
MessageData<Integer> removeMessage = (MessageData<Integer>) Util.castNonNull(message);
|
||||||
int fromIndex = removeMessage.index;
|
int fromIndex = removeMessage.index;
|
||||||
int toIndex = removeMessage.customData;
|
int toIndex = removeMessage.customData;
|
||||||
if (fromIndex == 0 && toIndex == shuffleOrder.getLength()) {
|
if (fromIndex == 0 && toIndex == shuffleOrder.getLength()) {
|
||||||
@ -573,14 +574,15 @@ public class ConcatenatingMediaSource extends CompositeMediaSource<MediaSourceHo
|
|||||||
scheduleListenerNotification(removeMessage.actionOnCompletion);
|
scheduleListenerNotification(removeMessage.actionOnCompletion);
|
||||||
break;
|
break;
|
||||||
case MSG_MOVE:
|
case MSG_MOVE:
|
||||||
MessageData<Integer> moveMessage = (MessageData<Integer>) message;
|
MessageData<Integer> moveMessage = (MessageData<Integer>) Util.castNonNull(message);
|
||||||
shuffleOrder = shuffleOrder.cloneAndRemove(moveMessage.index);
|
shuffleOrder = shuffleOrder.cloneAndRemove(moveMessage.index);
|
||||||
shuffleOrder = shuffleOrder.cloneAndInsert(moveMessage.customData, 1);
|
shuffleOrder = shuffleOrder.cloneAndInsert(moveMessage.customData, 1);
|
||||||
moveMediaSourceInternal(moveMessage.index, moveMessage.customData);
|
moveMediaSourceInternal(moveMessage.index, moveMessage.customData);
|
||||||
scheduleListenerNotification(moveMessage.actionOnCompletion);
|
scheduleListenerNotification(moveMessage.actionOnCompletion);
|
||||||
break;
|
break;
|
||||||
case MSG_SET_SHUFFLE_ORDER:
|
case MSG_SET_SHUFFLE_ORDER:
|
||||||
MessageData<ShuffleOrder> shuffleOrderMessage = (MessageData<ShuffleOrder>) message;
|
MessageData<ShuffleOrder> shuffleOrderMessage =
|
||||||
|
(MessageData<ShuffleOrder>) Util.castNonNull(message);
|
||||||
shuffleOrder = shuffleOrderMessage.customData;
|
shuffleOrder = shuffleOrderMessage.customData;
|
||||||
scheduleListenerNotification(shuffleOrderMessage.actionOnCompletion);
|
scheduleListenerNotification(shuffleOrderMessage.actionOnCompletion);
|
||||||
break;
|
break;
|
||||||
@ -588,7 +590,7 @@ public class ConcatenatingMediaSource extends CompositeMediaSource<MediaSourceHo
|
|||||||
notifyListener();
|
notifyListener();
|
||||||
break;
|
break;
|
||||||
case MSG_ON_COMPLETION:
|
case MSG_ON_COMPLETION:
|
||||||
List<Runnable> actionsOnCompletion = ((List<Runnable>) message);
|
List<Runnable> actionsOnCompletion = (List<Runnable>) Util.castNonNull(message);
|
||||||
Handler handler = Assertions.checkNotNull(playerApplicationHandler);
|
Handler handler = Assertions.checkNotNull(playerApplicationHandler);
|
||||||
for (int i = 0; i < actionsOnCompletion.size(); i++) {
|
for (int i = 0; i < actionsOnCompletion.size(); i++) {
|
||||||
handler.post(actionsOnCompletion.get(i));
|
handler.post(actionsOnCompletion.get(i));
|
||||||
|
@ -378,7 +378,7 @@ public class MediaCodecVideoRenderer extends MediaCodecRenderer {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(int messageType, Object message) throws ExoPlaybackException {
|
public void handleMessage(int messageType, @Nullable Object message) throws ExoPlaybackException {
|
||||||
if (messageType == C.MSG_SET_SURFACE) {
|
if (messageType == C.MSG_SET_SURFACE) {
|
||||||
setSurface((Surface) message);
|
setSurface((Surface) message);
|
||||||
} else if (messageType == C.MSG_SET_SCALING_MODE) {
|
} else if (messageType == C.MSG_SET_SCALING_MODE) {
|
||||||
|
@ -57,7 +57,7 @@ public class CameraMotionRenderer extends BaseRenderer {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(int messageType, Object message) throws ExoPlaybackException {
|
public void handleMessage(int messageType, @Nullable Object message) throws ExoPlaybackException {
|
||||||
if (messageType == C.MSG_SET_CAMERA_MOTION_LISTENER) {
|
if (messageType == C.MSG_SET_CAMERA_MOTION_LISTENER) {
|
||||||
listener = (CameraMotionListener) message;
|
listener = (CameraMotionListener) message;
|
||||||
} else {
|
} else {
|
||||||
|
@ -1964,7 +1964,7 @@ public final class ExoPlayerTest {
|
|||||||
Renderer videoRenderer =
|
Renderer videoRenderer =
|
||||||
new FakeRenderer(Builder.VIDEO_FORMAT) {
|
new FakeRenderer(Builder.VIDEO_FORMAT) {
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(int what, Object object) throws ExoPlaybackException {
|
public void handleMessage(int what, @Nullable Object object) throws ExoPlaybackException {
|
||||||
super.handleMessage(what, object);
|
super.handleMessage(what, object);
|
||||||
rendererMessages.add(what);
|
rendererMessages.add(what);
|
||||||
}
|
}
|
||||||
@ -2455,7 +2455,7 @@ public final class ExoPlayerTest {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void handleMessage(SimpleExoPlayer player, int messageType, Object message) {
|
public void handleMessage(SimpleExoPlayer player, int messageType, @Nullable Object message) {
|
||||||
if (player != null) {
|
if (player != null) {
|
||||||
windowIndex = player.getCurrentWindowIndex();
|
windowIndex = player.getCurrentWindowIndex();
|
||||||
positionMs = player.getCurrentPosition();
|
positionMs = player.getCurrentPosition();
|
||||||
|
@ -447,7 +447,8 @@ public final class ActionSchedule {
|
|||||||
private SimpleExoPlayer player;
|
private SimpleExoPlayer player;
|
||||||
|
|
||||||
/** Handles the message send to the component and additionally provides access to the player. */
|
/** Handles the message send to the component and additionally provides access to the player. */
|
||||||
public abstract void handleMessage(SimpleExoPlayer player, int messageType, Object message);
|
public abstract void handleMessage(
|
||||||
|
SimpleExoPlayer player, int messageType, @Nullable Object message);
|
||||||
|
|
||||||
/** Sets the player to be passed to {@link #handleMessage(SimpleExoPlayer, int, Object)}. */
|
/** Sets the player to be passed to {@link #handleMessage(SimpleExoPlayer, int, Object)}. */
|
||||||
/* package */ void setPlayer(SimpleExoPlayer player) {
|
/* package */ void setPlayer(SimpleExoPlayer player) {
|
||||||
@ -455,7 +456,8 @@ public final class ActionSchedule {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public final void handleMessage(int messageType, Object message) throws ExoPlaybackException {
|
public final void handleMessage(int messageType, @Nullable Object message)
|
||||||
|
throws ExoPlaybackException {
|
||||||
handleMessage(player, messageType, message);
|
handleMessage(player, messageType, message);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user