loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix build error when androidxMediaModulePrefix is specified

Browse Source 
When the media3 modules are referred from an external project and
gradle.ext.androidxMediaModulePrefix is specified, build error occurs
like the following.

> gradle.ext.androidxMediaModulePrefix = "media-"

> A problem occurred evaluating project ':media-lib-common'.
> > Project with path ':media-media-lib-cast' could not be found in project ':media-lib-common'.

As you can see, the build script of the common module is trying to
use an incorrect named project which has duplicated prefixes.
This commit is contained in:
Haruki Hasegawa 2022-01-30 17:24:47 +09:00
parent 2521ee6d9f
commit 1074078d2b
No known key found for this signature in database
GPG Key ID: B904442AFD173739
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libraries/common/build.gradle
View File

@ -17,9 +17,9 @@ apply from: "$gradle.ext.androidxMediaSettingsDir/common_library_config.gradle"
// the Gradle properties of each library are populated and we can automatically // the Gradle properties of each library are populated and we can automatically
// check if a 'releaseArtifactId' exists. // check if a 'releaseArtifactId' exists.
rootProject.allprojects.forEach { rootProject.allprojects.forEach {
if ((it.name.contains('lib-') || it.name.contains('test-')) if ((it.name.startsWith(modulePrefix.replace(':', '') + 'lib-') || it.name.startsWith(modulePrefix.replace(':', '') + 'test-'))
&& !it.name.endsWith('-common')) { && !it.name.endsWith('-common')) {
evaluationDependsOn(modulePrefix + it.name) evaluationDependsOn(':' + it.name)
} }
} }
// copybara:media3-only // copybara:media3-only
@ -36,8 +36,8 @@ dependencies {
// List all released targets as constraints. This ensures they are all // List all released targets as constraints. This ensures they are all
// resolved to the same version. // resolved to the same version.
rootProject.allprojects.forEach { rootProject.allprojects.forEach {
if (it.hasProperty('releaseArtifactId')) { if (it.hasProperty('releaseArtifactId') && it.releaseArtifactId.startsWith('media3-')) {
implementation project(modulePrefix + it.name) implementation project(':' + it.name)
} }
} }
} }