loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use Suppliers.memoize for lazy instantiation of AudioManager

Browse Source
This commit is contained in:
Colin Kho 2024-08-14 10:35:29 -07:00 committed by Ian Baker
parent 6af92b0af3
commit 0a0444b9a5
1 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/AudioFocusManager.java
View File

@ -32,6 +32,8 @@ import androidx.media3.common.Player;
import androidx.media3.common.util.Assertions; import androidx.media3.common.util.Assertions;
import androidx.media3.common.util.Log; import androidx.media3.common.util.Log;
import androidx.media3.common.util.Util; import androidx.media3.common.util.Util;
import com.google.common.base.Supplier;
import com.google.common.base.Suppliers;
import java.lang.annotation.Documented; import java.lang.annotation.Documented;
import java.lang.annotation.Retention; import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy; import java.lang.annotation.RetentionPolicy;
@ -161,14 +163,12 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
private static final float VOLUME_MULTIPLIER_DEFAULT = 1.0f; private static final float VOLUME_MULTIPLIER_DEFAULT = 1.0f;
private final AudioFocusListener focusListener; private final AudioFocusListener focusListener;
private final Context applicationContext; private final Supplier<AudioManager> audioManager;
@Nullable private PlayerControl playerControl; @Nullable private PlayerControl playerControl;
@Nullable private AudioAttributes audioAttributes; @Nullable private AudioAttributes audioAttributes;
@Nullable private AudioManager audioManager;
private @AudioFocusState int audioFocusState; private @AudioFocusState int audioFocusState;
private @AudioFocusGain int focusGainToRequest; private @AudioFocusGain int focusGainToRequest;
private float volumeMultiplier = VOLUME_MULTIPLIER_DEFAULT; private float volumeMultiplier = VOLUME_MULTIPLIER_DEFAULT;
private @MonotonicNonNull AudioFocusRequest audioFocusRequest; private @MonotonicNonNull AudioFocusRequest audioFocusRequest;
private boolean rebuildAudioFocusRequest; private boolean rebuildAudioFocusRequest;
@ -180,7 +180,9 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
* @param playerControl A {@link PlayerControl} to handle commands from this instance. * @param playerControl A {@link PlayerControl} to handle commands from this instance.
*/ */
public AudioFocusManager(Context context, Handler eventHandler, PlayerControl playerControl) { public AudioFocusManager(Context context, Handler eventHandler, PlayerControl playerControl) {
this.applicationContext = context; this.audioManager =
Suppliers.memoize(() -> checkNotNull(
(AudioManager) context.getApplicationContext().getSystemService(Context.AUDIO_SERVICE)));
this.playerControl = playerControl; this.playerControl = playerControl;
this.focusListener = new AudioFocusListener(eventHandler); this.focusListener = new AudioFocusListener(eventHandler);
this.audioFocusState = AUDIO_FOCUS_STATE_NOT_REQUESTED; this.audioFocusState = AUDIO_FOCUS_STATE_NOT_REQUESTED;
@ -285,7 +287,7 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
} }
private int requestAudioFocusDefault() { private int requestAudioFocusDefault() {
return getAudioManager().requestAudioFocus( return audioManager.get().requestAudioFocus(
focusListener, focusListener,
Util.getStreamTypeForAudioUsage(checkNotNull(audioAttributes).usage), Util.getStreamTypeForAudioUsage(checkNotNull(audioAttributes).usage),
focusGainToRequest); focusGainToRequest);
@ -310,17 +312,17 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
rebuildAudioFocusRequest = false; rebuildAudioFocusRequest = false;
} }
return getAudioManager().requestAudioFocus(audioFocusRequest); return audioManager.get().requestAudioFocus(audioFocusRequest);
} }
private void abandonAudioFocusDefault() { private void abandonAudioFocusDefault() {
getAudioManager().abandonAudioFocus(focusListener); audioManager.get().abandonAudioFocus(focusListener);
} }
@RequiresApi(26) @RequiresApi(26)
private void abandonAudioFocusV26() { private void abandonAudioFocusV26() {
if (audioFocusRequest != null) { if (audioFocusRequest != null) {
getAudioManager().abandonAudioFocusRequest(audioFocusRequest); audioManager.get().abandonAudioFocusRequest(audioFocusRequest);
} }
} }
@ -453,13 +455,6 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
} }
} }
private AudioManager getAudioManager() {
if (audioManager == null) {
audioManager = (AudioManager) applicationContext.getSystemService(Context.AUDIO_SERVICE);
}
return audioManager;
}
// Internal audio focus listener. // Internal audio focus listener.
private class AudioFocusListener implements AudioManager.OnAudioFocusChangeListener { private class AudioFocusListener implements AudioManager.OnAudioFocusChangeListener {