loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check if there is a current context before generating textures/FBOs.

Browse Source 
This avoids silent failures where the generated identifiers are 0.

PiperOrigin-RevId: 437775689
This commit is contained in:
hschlueter 2022-03-28 17:17:03 +01:00 committed by Ian Baker
parent d2a9419ad3
commit 0724e2b99f
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/common/src/main/java/androidx/media3/common/util/GlUtil.java
View File

@ -371,6 +371,9 @@ public final class GlUtil {
* GLES11Ext#GL_TEXTURE_EXTERNAL_OES} for an external texture. * GLES11Ext#GL_TEXTURE_EXTERNAL_OES} for an external texture.
*/ */
private static int generateAndBindTexture(int textureTarget) { private static int generateAndBindTexture(int textureTarget) {
checkEglException(
!Util.areEqual(EGL14.eglGetCurrentContext(), EGL14.EGL_NO_CONTEXT), "No current context");
int[] texId = new int[1]; int[] texId = new int[1];
GLES20.glGenTextures(/* n= */ 1, texId, /* offset= */ 0); GLES20.glGenTextures(/* n= */ 1, texId, /* offset= */ 0);
checkGlError(); checkGlError();
@ -391,6 +394,9 @@ public final class GlUtil {
* @param texId The identifier of the texture to attach to the framebuffer. * @param texId The identifier of the texture to attach to the framebuffer.
*/ */
public static int createFboForTexture(int texId) { public static int createFboForTexture(int texId) {
checkEglException(
!Util.areEqual(EGL14.eglGetCurrentContext(), EGL14.EGL_NO_CONTEXT), "No current context");
int[] fboId = new int[1]; int[] fboId = new int[1];
GLES20.glGenFramebuffers(/* n= */ 1, fboId, /* offset= */ 0); GLES20.glGenFramebuffers(/* n= */ 1, fboId, /* offset= */ 0);
checkGlError(); checkGlError();