From 060356ea0026efa516cc3b2973cf0743d4b3d797 Mon Sep 17 00:00:00 2001 From: claincly Date: Mon, 2 Sep 2024 06:13:02 -0700 Subject: [PATCH] Temporarily disable multi-sequence audio playback test Disable assertions and make sure playback passes. The flake is caused by having different sequences starting with MediaItems of different audio format, and it's undefined behaviour as to which one CompositionPlayer chooses to use. PiperOrigin-RevId: 670195113 --- .../CompositionPlayerAudioPlaybackTest.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/libraries/transformer/src/test/java/androidx/media3/transformer/CompositionPlayerAudioPlaybackTest.java b/libraries/transformer/src/test/java/androidx/media3/transformer/CompositionPlayerAudioPlaybackTest.java index 59b8d43685..f72eff563b 100644 --- a/libraries/transformer/src/test/java/androidx/media3/transformer/CompositionPlayerAudioPlaybackTest.java +++ b/libraries/transformer/src/test/java/androidx/media3/transformer/CompositionPlayerAudioPlaybackTest.java @@ -289,10 +289,7 @@ public final class CompositionPlayerAudioPlaybackTest { TestPlayerRunHelper.runUntilPlaybackState(player, Player.STATE_ENDED); player.release(); - DumpFileAsserts.assertOutput( - context, - capturingAudioSink, - "audiosinkdumps/wav/compositionPlayback_withShortLoopingSequence_outputsCorrectSamples.dump"); + // TODO: b/363229593 - Change dump file after format handling is fixed. } @Test @@ -318,10 +315,7 @@ public final class CompositionPlayerAudioPlaybackTest { TestPlayerRunHelper.runUntilPlaybackState(player, Player.STATE_ENDED); player.release(); - DumpFileAsserts.assertOutput( - context, - capturingAudioSink, - "audiosinkdumps/wav/compositionPlayback_withLongLoopingSequence_outputsCorrectSamples.dump"); + // TODO: b/363229593 - Change dump file after format handling is fixed. } @Test