From 01f85394d293c074f552ef4637b9e2772354313e Mon Sep 17 00:00:00 2001 From: olly Date: Mon, 10 May 2021 15:00:47 +0100 Subject: [PATCH] Clean up RtspMediaSource.Factory - Don't deprecate methods not deprecated in the base class and that could one day be useful. - Better document deprecation of other methods. #minor-release PiperOrigin-RevId: 372919080 --- .../source/rtsp/RtspMediaSource.java | 25 +++++++++++++------ 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java b/library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java index 199ba11a2a..e4e49306b7 100644 --- a/library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java +++ b/library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java @@ -58,22 +58,29 @@ public final class RtspMediaSource extends BaseMediaSource { */ public static final class Factory implements MediaSourceFactory { - /** @deprecated Not supported. */ - @Deprecated + /** Does nothing. {@link RtspMediaSource} does not support DRM. */ @Override public Factory setDrmSessionManagerProvider( @Nullable DrmSessionManagerProvider drmSessionManager) { return this; } - /** @deprecated Not supported. */ + /** + * Does nothing. {@link RtspMediaSource} does not support DRM. + * + * @deprecated {@link RtspMediaSource} does not support DRM. + */ @Deprecated @Override public Factory setDrmSessionManager(@Nullable DrmSessionManager drmSessionManager) { return this; } - /** @deprecated Not supported. */ + /** + * Does nothing. {@link RtspMediaSource} does not support DRM. + * + * @deprecated {@link RtspMediaSource} does not support DRM. + */ @Deprecated @Override public Factory setDrmHttpDataSourceFactory( @@ -81,18 +88,22 @@ public final class RtspMediaSource extends BaseMediaSource { return this; } - /** @deprecated Not supported. */ + /** + * Does nothing. {@link RtspMediaSource} does not support DRM. + * + * @deprecated {@link RtspMediaSource} does not support DRM. + */ @Deprecated @Override public Factory setDrmUserAgent(@Nullable String userAgent) { return this; } - /** @deprecated Not supported. */ - @Deprecated + /** Does nothing. {@link RtspMediaSource} does not support error handling policies. */ @Override public Factory setLoadErrorHandlingPolicy( @Nullable LoadErrorHandlingPolicy loadErrorHandlingPolicy) { + // TODO(internal b/172331505): Implement support. return this; }