mirror of
https://github.com/androidx/media.git
synced 2025-04-30 06:46:50 +08:00
9bb254f697
The file in Issue: androidx/media#2052 contains a cue with the following timecode: ``` 0:00:00:00,0:00:00:00 ``` The content of this cue seems to be some 'converted by' metadata, i.e. it's basically a comment and clearly not intended to be shown on screen (since it has zero duration). There is some fiddly logic later in `SsaParser` to support overlapping cues with the old `Subtitle` structure [1], and this logic gets tripped up by the start and end time being equal, which results in a **single**, empty `List<Cue>` being added - which trips up another assumption that every SSA cue line results in at least two `List<Cue>` entries (one containing the cue text, and another containing an empty list to signal the end of the cues). This fiddly logic is no longer required, because overlapping `CuesWithTiming` objects can now be merged in `TextRenderer`, so there is a possible future simplification to `SsaParser` which removes a lot of this complexity. [1] Added in <unknown commit> PiperOrigin-RevId: 718380386