mirror of
https://github.com/androidx/media.git
synced 2025-05-16 03:59:54 +08:00
5056dfaa2b
7e65cce967introduced a regression on ExoPlayer.setVideoEffects() where there is flash on the screen after the first few frames are shown. Before7e65cce967, the first frames of the content are missed, until MediaCodecVideoRenderer sends the onVideoSizeChanged() callback. The first frame is processed but not shown, the onVideoSizeChanged() is triggered and the renderer receives a video output resolution message as a response from the UI.7e65cce967fixed the missed first frames by setting a surface on the CompositingVideoSinkProvider before the provider is initialized, and as as result: - the first frames are rendered - the MediaCodecVideoRenderer sends the the onVideoSizeChanged() after frames are shown - the UI sends a video output resolution change - the MediaCodecVideoRenderer updates the CompositingVideoSinkProvider which causes the flash. The underlying problem is with onVideoSizeChanged() not being triggered early enough, before the first frame is shown. Because the flashing is a regression, this commit is reverting7e65cce967but keeps the test that was added as ignored, so that the test is re-enabled as soon as we address the underlying issue. PiperOrigin-RevId: 597814013