4892 Commits

Author SHA1 Message Date
olly
37af6ac03c Bump version to 2.8.4
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=209134753
2018-08-17 13:34:10 +01:00
andrewlewis
e7bbdbf59d Enable IMA SDK debug mode if flag is set
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=208054150
2018-08-17 11:30:38 +01:00
andrewlewis
5c118f9741 Release ads loader on new intent in the demo app
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=208056265
2018-08-17 11:28:09 +01:00
andrewlewis
e9e1c08cd2 Improve handling of consecutive empty ad groups
Issue: #4030
Issue: #4280

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=208055792
2018-08-17 11:28:06 +01:00
bachinger
7572461115 adjust timestamps for cea608 and emsg in FMP4
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=208526775
2018-08-17 11:21:10 +01:00
olly
4662e586cd Add more information to unexpected assertion failure
Issue: #4532

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=208968252
2018-08-17 11:20:43 +01:00
Oliver Woodman
95bc60798e Fix silence skipping test 2018-08-07 19:06:49 +01:00
ojw28
8cbcfd669d
Merge pull request #4556 from google/dev-v2-r2.8.3
r2.8.3
2018-08-07 15:50:14 +01:00
Oliver Woodman
563f13a832 Adjust trim silence parameters to make it less aggressive. 2018-08-07 15:47:57 +01:00
Oliver Woodman
74ac722b55 Fix fullscreen icons to be the correct size 2018-08-06 14:52:46 +01:00
Oliver Woodman
27f05c412d Remove Java 8 usage from release 2018-08-06 13:34:53 +01:00
andrewlewis
4cd57e0963 Fix DefaultTimeBar accessibility class name
See https://support.google.com/accessibility/android/answer/7661305.

Also fix/suppress nullability warnings.

Issue: #4611

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=207245115
2018-08-06 13:31:33 +01:00
olly
e92d65533f Fix freezing playing multi-period DASH with EventStreams
EventSampleStream.readData required eventStreamUpdatable to be
false for END_OF_STREAM to be returned, but it was only being
set to false when the manifest became static. This change also
sets it to false if the period is not the last one in a dynamic
manifest. It also renames it the parameter to appendable, since
that's what it really represents. Events may still be removed
from the start of the EventStream as the period starts moving
out of the live window.

Issue: #4492

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=207517265
2018-08-06 13:30:14 +01:00
olly
5ce9ce56f3 Minimal fix for non-default cenc name prefixes in DASH manifests
For now, just allow any prefix (and don't check the namespace).
Checking the namespace requires turning on the XmlPullParser
namespace awareness feature, but this can only be done before
parsing, and I think requires us to specify the namespace when
querying other attributes. This would also risk breaking services
who currently don't set namespaces correctly.

It's possible we'll run into similar issues with the few other
tags (e.g. mspr:pro). We should revisit enabling namespace
awareness if/when we see this.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=207526883
2018-08-06 13:30:01 +01:00
Oliver Woodman
180d6ae902 Disable tests that fail on some host machines 2018-08-01 19:58:05 +01:00
Oliver Woodman
96c8557e00 Release fixes 2018-08-01 19:02:32 +01:00
aquilescanta
fa1049ec5e Fix SCTE-35 timestamp adjustment
Issue:#4573

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=206737252
2018-08-01 14:17:48 +01:00
eguven
c41f955f0f Disable automatic imports for inner classes
Inner classes generally has generic names and they make sense when they
are considered with the top level class they appear in.

When this setting is disabled, Android Studio inserts import for the top
level class and append the top level class's name before the reference
to the inner class name.

NO_SQ

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=206127763
2018-08-01 14:16:26 +01:00
olly
00891f6469 Don't exclude .idea from MOE input
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=205988261
2018-08-01 14:16:19 +01:00
olly
5faa662e43 Apply setOutputSurfaceWorkaround to required FireOS devices
Amazon like to use Device.MODEL, so key on that instead for
these workarounds.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=206917935
2018-08-01 14:16:09 +01:00
eguven
ed18be4eea Add missing Nullable annotation Player.EventListener.onTimelineChanged
Issue: #4593

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=206911927
2018-08-01 14:15:58 +01:00
olly
a3e3f64b79 Add PRO7S to surface switch workaround
Issue: #4468

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=205821059
2018-07-24 15:01:40 +01:00
olly
a3de7bf399 Update release notes + bump version
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=205660355
2018-07-23 16:04:31 +01:00
Oliver Woodman
b0f44029b7 Clean up release notes 2018-07-23 14:49:33 +01:00
andrewlewis
f39d28135d Pass through all ID3 internal data from udta
Also switch from using a CommentFrame to a new InternalFrame type for ID3 data
stored with ID '----', to distinguish internal data from actual ID3 comments.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=201315254
2018-07-23 14:36:37 +01:00
olly
224d0c2b2c Add isControllerVisible
Issue: #4385

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=200986828
2018-07-23 14:35:14 +01:00
Oliver Woodman
dcd549bd3e Fix release branch 2018-07-23 14:06:29 +01:00
Oliver Woodman
50c8197004 Widen setOutputSurface workaround 2018-07-23 14:03:59 +01:00
tonihei
7d4ac516e7 Update period index in DashMediaPeriod event dispatcher after manifest update.
Issue:#4492

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=205636634
2018-07-23 13:58:47 +01:00
tonihei
e03623f701 Fix issue with keeping window sequence number after repeated seeks.
The number is shelved in calls to queue.clear() to keep it for the next
media period. However, the queue may also become empty by repeated calls to
advancePlayingPeriod which may happen when seeking to an unprepared period.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=205376036
2018-07-23 13:58:04 +01:00
andrewlewis
9bb64b7e44 Add support for setting companion ad slots
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=205373398
2018-07-23 13:57:21 +01:00
olly
0b8724cb66 Fix bug where sourceId wasn't set for the first chunk
The sample queues haven't been created when the first init call
occurs. In this case we need to set sourceId when we subsequently
create the queues.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=204467538
2018-07-23 13:56:04 +01:00
hoangtc
d24e7cdffe Fix a bug with TTML using font size as % of cellResolution.
After [] we support default font size for TTML, relative to the cellResolution of the document. However, this introduced a bug that makes TTML font-size in such case always follow the cellResolution font size, even when SubtitleView.setApplyEmbeddedStyles(false) and SubtitleView.setApplyEmbeddedFontSizes(false) were used.

This CL updates the fix so that the default font-size using cellResolution works in the same way as other embedded styles, and can be turned off using setters from SubtitleView.

GitHub: #4491

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=204467033
2018-07-23 13:55:41 +01:00
andrewlewis
0a46e74105 Ignore all edit lists if one track's edits can't be applied
Issue: #4348

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=204261718
2018-07-23 13:54:12 +01:00
eguven
2f6273c9fc Fix DownloadService doesn't stop when the app is killed
Also fixed showing "remove notification" when download is completed.

Issue:#4469
Issue:#4488

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203927268
2018-07-23 13:53:52 +01:00
olly
44c45fd18d Move subsampleOffset in Format
It's no longer text specific (it's used for metadata as well, and
in theory could apply to any stream in which samples contain multiple
sub-samples)

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203767825
2018-07-23 13:53:38 +01:00
tonihei
7e9e29d8a8 Fix wrong loop variable in DashMediaPeriod.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203766579
2018-07-23 13:53:32 +01:00
tonihei
522adc3772 Restructure track selection in DashMediaPeriod.
Until now, the streams were released and re-enabled for each type of stream
(primary, event, embedded) in that order. That leads to problems when replacing
streams from one type to another (for example embedded to primary).

This change restructures the track selection to:
1. Release and reset all streams that need to be released or replaced.
 1(a). Including embedded orphan streams.
2. Select new streams.

Issue:#4477

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203751233
2018-07-23 13:53:26 +01:00
olly
d49c5a476d Tweak DefaultTrackSelector documentation
Viewport constraints apply to adaptive content even if the
actual playback isn't adaptive (i.e. because the selector
ends up making a fixed track selection).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203726831
2018-07-23 13:53:10 +01:00
Drew Hill
7207665ce0 flip flag values to their proper names so that trackselector parameters can be useful 2018-07-23 13:52:55 +01:00
tonihei
f2f149adca Add workaround for unmatched track indices in tkhd and tfhd.
If there is only one track, we can assume that both boxes refer to the same track
even if the track indices don't match.

Issue:#4083

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203485872
2018-07-23 13:52:49 +01:00
olly
6ad98405a3 Avoid providing invalid responses to MediaDrm
MediaDrm.provideXResponse methods only accept the response
corresponding to the most recent MediaDrm.getXRequest call.
Previously, our code allowed the following incorrect call
sequence:

a = getKeyRequest
b = getKeyRequest
provideKeyResponse(responseFor(a));

This would occur in the edge case of a second key request
being triggered whilst the first was still in flight. The
provideKeyResponse call would then fail.

This change fixes the problem by treating responseFor(a)
as stale. Note that a slightly better fix would be to
defer calling getKeyRequest the second time until after
processing the response corresponding to the first one,
however this is significantly harder to implement, and is
probably not worth it for what should be an edge case.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203481685
2018-07-23 13:52:41 +01:00
tonihei
a50d31a70b Add workaround for unmatched track indices in trex and tkhd.
Both boxes should contain the same list of track indices. However, if only one
track index in each list does not match, we can just assume that these belong
together.

Issue:#4477

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203481258
2018-07-23 13:52:33 +01:00
olly
1f188c7c00 Exclude text streams from duration calculations
Issue: #4029

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202912333
2018-07-23 13:50:56 +01:00
olly
165fef8782 Fix application of styles for CEA-608
Issue: #4321

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202660712
2018-07-23 13:50:23 +01:00
olly
3c4384ddd9 Simplify DefaultTrackSelector documentation
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202623116
2018-07-23 13:48:50 +01:00
olly
6cdaf593e0 Improve DefaultTrackSelector documentation
It's quite hard to find the defaults currently. Placing them
on each variable makes them easier to find.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202495929
2018-07-23 13:48:43 +01:00
tonihei
186711287b Add some leeway for finding additional tracks in PsExtractor.
Currently we immediately stop searching after we found one video and one
audio track. This change adds some leeway to detect additional tracks.

Issue:#4406

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202455491
2018-07-23 13:48:18 +01:00
tonihei
a0810856e7 Add DRM workaround for Asus Zenfone 2.
Issue: #4413

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202277924
2018-07-23 13:47:53 +01:00
aquilescanta
be995f0b27 Rename HlsPlaylistTracker's release to stop
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202103550
2018-07-23 13:46:10 +01:00