From 8466a957c3471c8e6fdb06dc77425424c531c61b Mon Sep 17 00:00:00 2001 From: Gilles Khouzam Date: Tue, 19 Nov 2024 10:10:10 -0800 Subject: [PATCH 1/2] Make MediaCodecVideoRenderer::shouldUsePlaceholderSurface protected. This enables a derived renderer to disable the placeholder surface. --- .../media3/exoplayer/video/MediaCodecVideoRenderer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/MediaCodecVideoRenderer.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/MediaCodecVideoRenderer.java index 5250e1107f..3b94f6ac39 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/MediaCodecVideoRenderer.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/MediaCodecVideoRenderer.java @@ -1882,7 +1882,7 @@ public class MediaCodecVideoRenderer extends MediaCodecRenderer return Util.SDK_INT >= 35 && codecInfo.detachedSurfaceSupported; } - private boolean shouldUsePlaceholderSurface(MediaCodecInfo codecInfo) { + protected boolean shouldUsePlaceholderSurface(MediaCodecInfo codecInfo) { return Util.SDK_INT >= 23 && !tunneling && !codecNeedsSetOutputSurfaceWorkaround(codecInfo.name) From ad18ae9c42177d1f539db08420734d85f5209820 Mon Sep 17 00:00:00 2001 From: microkatz Date: Thu, 30 Jan 2025 11:40:56 +0000 Subject: [PATCH 2/2] Added release note --- RELEASENOTES.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/RELEASENOTES.md b/RELEASENOTES.md index 49d8d1b585..e014b83ae5 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -11,6 +11,10 @@ * Audio: * Make `androidx.media3.common.audio.SonicAudioProcessor` final. * Video: + * Change `MediaCodecVideoRenderer.shouldUsePlaceholderSurface` to + protected so that applications can override to block usage of + placeholder surfaces + ([#1905](https://github.com/androidx/media/pull/1905)). * Text: * Metadata: * Image: