loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-05-18 13:09:56 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Split MediaItemTest#setSubtitles into two tests

Browse Source 
Each test exercises one of the setters. Together they assert that both
setters set both fields.

PiperOrigin-RevId: 408309207
This commit is contained in:
ibaker 2021-11-08 12:41:43 +00:00 committed by tonihei
parent 57df39ffb8
commit f9c1cab541
1 changed files with 23 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
library/common/src/test/java/com/google/android/exoplayer2/MediaItemTest.java
View File

@ -268,8 +268,8 @@ public class MediaItemTest {
}
@Test
@SuppressWarnings("deprecation") // Using deprecated Subtitle type
public void builderSetSubtitles_setsSubtitles() {
@SuppressWarnings("deprecation") // Reading deprecated subtitles field
public void builderSetSubtitleConfigurations() {
List<MediaItem.SubtitleConfiguration> subtitleConfigurations =
ImmutableList.of(
new MediaItem.SubtitleConfiguration.Builder(Uri.parse(URI_STRING + "/es"))
@ -278,7 +278,24 @@ public class MediaItemTest {
.setSelectionFlags(C.SELECTION_FLAG_FORCED)
.setRoleFlags(C.ROLE_FLAG_ALTERNATE)
.setLabel("label")
.build(),
.build());
MediaItem mediaItem =
new MediaItem.Builder()
.setUri(URI_STRING)
.setSubtitleConfigurations(subtitleConfigurations)
.build();
assertThat(mediaItem.localConfiguration.subtitleConfigurations)
.isEqualTo(subtitleConfigurations);
assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitleConfigurations);
}
@Test
@SuppressWarnings("deprecation") // Using deprecated Subtitle type
public void builderSetSubtitles() {
List<MediaItem.Subtitle> subtitles =
ImmutableList.of(
new MediaItem.Subtitle(
Uri.parse(URI_STRING + "/en"), MimeTypes.APPLICATION_TTML, /* language= */ "en"),
new MediaItem.Subtitle(
@ -295,14 +312,10 @@ public class MediaItemTest {
"label"));
MediaItem mediaItem =
new MediaItem.Builder()
.setUri(URI_STRING)
.setSubtitleConfigurations(subtitleConfigurations)
.build();
new MediaItem.Builder().setUri(URI_STRING).setSubtitles(subtitles).build();
assertThat(mediaItem.localConfiguration.subtitleConfigurations)
.isEqualTo(subtitleConfigurations);
assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitleConfigurations);
assertThat(mediaItem.localConfiguration.subtitleConfigurations).isEqualTo(subtitles);
assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitles);
}
@Test