From f083ff264db8af76a1c9bb14bd72913b2fbb8fe2 Mon Sep 17 00:00:00 2001 From: ibaker Date: Wed, 25 Jan 2023 11:41:28 +0000 Subject: [PATCH] Document two limitations with subtitle sideloading #minor-release PiperOrigin-RevId: 504517946 --- docs/_includes/media3-known-issue-box.html | 2 ++ docs/media-items.md | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 docs/_includes/media3-known-issue-box.html diff --git a/docs/_includes/media3-known-issue-box.html b/docs/_includes/media3-known-issue-box.html new file mode 100644 index 0000000000..93d2989c04 --- /dev/null +++ b/docs/_includes/media3-known-issue-box.html @@ -0,0 +1,2 @@ +**[Known issue #{{include.issue-id}}](https://github.com/androidx/media/issues/{{include.issue-id}})** - {{ include.description }} +{:.error} diff --git a/docs/media-items.md b/docs/media-items.md index 0ba89db3d1..2361f19a27 100644 --- a/docs/media-items.md +++ b/docs/media-items.md @@ -102,7 +102,8 @@ MediaItem mediaItem = Internally, `DefaultMediaSourceFactory` will use a `MergingMediaSource` to combine the content media source with a `SingleSampleMediaSource` for each -subtitle track. +subtitle track. `DefaultMediaSourceFactory` does not support sideloading +subtitles for multi-period DASH. ## Clipping a media stream ## @@ -152,5 +153,7 @@ Internally, `DefaultMediaSourceFactory` will wrap the content media source in an the player also needs to have its `DefaultMediaSourceFactory` [configured accordingly]({{ site.baseurl }}/ad-insertion.html#declarative-ad-support). +{% include media3-known-issue-box.html issue-id="185" description="Subtitles, clipping and ad insertion are only supported if you use `DefaultMediaSourceFactory`." %} + [playlist API]: {{ site.baseurl }}/playlists.html [`MediaItem.Builder` Javadoc]: {{ site.exo_sdk }}/MediaItem.Builder.html