loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix 2 ErrorProneStyle findings:

Browse Source 
* These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them
  (see http://go/bugpattern/UnnecessaryParentheses) (2 times)

This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
* Suggest a fix on the CL (go/how-to-suggest-fix).
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.

This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/exoplayer/METADATA.
Anything wrong with the signup? File a bug at go/clrobot-bug.

#codehealth

PiperOrigin-RevId: 344053269
This commit is contained in:
olly 2020-11-24 15:21:02 +00:00 committed by kim-vde
parent 7a7d3d1b07
commit f04941ed91
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
library/extractor/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorNonParameterizedTest.java
View File

@ -176,14 +176,14 @@ public final class AmrExtractorNonParameterizedTest {
} }
private byte[] newWideBandAmrFrameWithType(int frameType) { private byte[] newWideBandAmrFrameWithType(int frameType) {
byte frameHeader = (byte) ((frameType << 3) & (0b01111100)); byte frameHeader = (byte) ((frameType << 3) & 0b01111100);
int frameContentInBytes = frameSizeBytesByTypeWb(frameType) - 1; int frameContentInBytes = frameSizeBytesByTypeWb(frameType) - 1;
return joinData(new byte[] {frameHeader}, randomBytesArrayWithLength(frameContentInBytes)); return joinData(new byte[] {frameHeader}, randomBytesArrayWithLength(frameContentInBytes));
} }
private byte[] newNarrowBandAmrFrameWithType(int frameType) { private byte[] newNarrowBandAmrFrameWithType(int frameType) {
byte frameHeader = (byte) ((frameType << 3) & (0b01111100)); byte frameHeader = (byte) ((frameType << 3) & 0b01111100);
int frameContentInBytes = frameSizeBytesByTypeNb(frameType) - 1; int frameContentInBytes = frameSizeBytesByTypeNb(frameType) - 1;
return joinData(new byte[] {frameHeader}, randomBytesArrayWithLength(frameContentInBytes)); return joinData(new byte[] {frameHeader}, randomBytesArrayWithLength(frameContentInBytes));