From f04941ed91ed6e9ca7f763bd122c90a19d62e63f Mon Sep 17 00:00:00 2001 From: olly Date: Tue, 24 Nov 2020 15:21:02 +0000 Subject: [PATCH] Fix 2 ErrorProneStyle findings: * These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them (see http://go/bugpattern/UnnecessaryParentheses) (2 times) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: " * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: ". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/exoplayer/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 344053269 --- .../extractor/amr/AmrExtractorNonParameterizedTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/extractor/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorNonParameterizedTest.java b/library/extractor/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorNonParameterizedTest.java index 65b8122c4a..4c31858a41 100644 --- a/library/extractor/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorNonParameterizedTest.java +++ b/library/extractor/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorNonParameterizedTest.java @@ -176,14 +176,14 @@ public final class AmrExtractorNonParameterizedTest { } private byte[] newWideBandAmrFrameWithType(int frameType) { - byte frameHeader = (byte) ((frameType << 3) & (0b01111100)); + byte frameHeader = (byte) ((frameType << 3) & 0b01111100); int frameContentInBytes = frameSizeBytesByTypeWb(frameType) - 1; return joinData(new byte[] {frameHeader}, randomBytesArrayWithLength(frameContentInBytes)); } private byte[] newNarrowBandAmrFrameWithType(int frameType) { - byte frameHeader = (byte) ((frameType << 3) & (0b01111100)); + byte frameHeader = (byte) ((frameType << 3) & 0b01111100); int frameContentInBytes = frameSizeBytesByTypeNb(frameType) - 1; return joinData(new byte[] {frameHeader}, randomBytesArrayWithLength(frameContentInBytes));