From e72082710c7deb5efa05f45e94de4f0ed12b92cc Mon Sep 17 00:00:00 2001 From: krocard Date: Tue, 20 Oct 2020 10:18:43 +0100 Subject: [PATCH] AudioSink: Remove comment about unconfirmed crash Consensus is that the NoClassDefFoundError does not causes a crash but only a warning. PiperOrigin-RevId: 338022354 --- .../google/android/exoplayer2/audio/DefaultAudioSink.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/audio/DefaultAudioSink.java b/library/core/src/main/java/com/google/android/exoplayer2/audio/DefaultAudioSink.java index 2ebd744812..4181bba1ca 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/audio/DefaultAudioSink.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/audio/DefaultAudioSink.java @@ -1702,9 +1702,9 @@ public final class DefaultAudioSink implements AudioSink { public StreamEventCallbackV29() { handler = new Handler(); - // StreamEventCallbackV29 can NOT inherit directly from AudioTrack.StreamEventCallback as it - // would cause a NoClassDefFoundError on the first load of DefaultAudioSink for SDK < 29 - // fatal on some devices. See: https://github.com/google/ExoPlayer/issues/8058 + // Avoid StreamEventCallbackV29 inheriting directly from AudioTrack.StreamEventCallback as it + // would cause a NoClassDefFoundError warning on load of DefaultAudioSink for SDK < 29. + // See: https://github.com/google/ExoPlayer/issues/8058 callback = new AudioTrack.StreamEventCallback() { @Override