loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-05-10 00:59:51 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Check MediaMetadata bundle to verify keys are skipped

Browse Source 
Added another check in test to make sure we don't add keys to bundle for fields with `null` values.

PiperOrigin-RevId: 496948705
(cherry picked from commit 890fd0a9fb135e938dc465d936b24065c65dbb98)
This commit is contained in:
rohks 2022-12-21 18:10:19 +00:00 committed by christosts
parent 0417dbae78
commit e4fa94abe3
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
library/common/src/test/java/com/google/android/exoplayer2/MediaMetadataTest.java
View File

@ -107,12 +107,17 @@ public class MediaMetadataTest {
} }
@Test @Test
public void createMinimalMediaMetadata_roundTripViaBundle_yieldsEqualInstance() { public void toBundleSkipsDefaultValues_fromBundleRestoresThem() {
MediaMetadata mediaMetadata = new MediaMetadata.Builder().build(); MediaMetadata mediaMetadata = new MediaMetadata.Builder().build();
MediaMetadata mediaMetadataFromBundle = Bundle mediaMetadataBundle = mediaMetadata.toBundle();
MediaMetadata.CREATOR.fromBundle(mediaMetadata.toBundle());
// check Bundle created above, contains no keys.
assertThat(mediaMetadataBundle.keySet()).isEmpty();
MediaMetadata mediaMetadataFromBundle = MediaMetadata.CREATOR.fromBundle(mediaMetadataBundle);
// check object retrieved from mediaMetadataBundle is equal to mediaMetadata.
assertThat(mediaMetadataFromBundle).isEqualTo(mediaMetadata); assertThat(mediaMetadataFromBundle).isEqualTo(mediaMetadata);
// Extras is not implemented in MediaMetadata.equals(Object o). // Extras is not implemented in MediaMetadata.equals(Object o).
assertThat(mediaMetadataFromBundle.extras).isNull(); assertThat(mediaMetadataFromBundle.extras).isNull();