From e47307d95ff82d2110fe9aaa4684dab3f41f6bb9 Mon Sep 17 00:00:00 2001 From: huangdarwin Date: Thu, 12 Jan 2023 16:01:29 +0000 Subject: [PATCH] Transformer: Simplify EncoderWrapper rotationDegrees logic. Small refactoring change to simplify the logic a tiny bit by removing one unnecessary variable. No functional change intended. PiperOrigin-RevId: 501566533 --- .../androidx/media3/transformer/VideoSamplePipeline.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/VideoSamplePipeline.java b/libraries/transformer/src/main/java/androidx/media3/transformer/VideoSamplePipeline.java index 0ffc3fc7b4..58d4916041 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/VideoSamplePipeline.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/VideoSamplePipeline.java @@ -425,8 +425,7 @@ import org.checkerframework.dataflow.qual.Pure; // frame before encoding, so the encoded frame's width >= height, and sets // rotationDegrees in the output Format to ensure the frame is displayed in the correct // orientation. - boolean flipOrientation = requestedWidth < requestedHeight; - if (flipOrientation) { + if (requestedWidth < requestedHeight) { int temp = requestedWidth; requestedWidth = requestedHeight; requestedHeight = temp; @@ -477,7 +476,7 @@ import org.checkerframework.dataflow.qual.Pure; fallbackListener.onTransformationRequestFinalized( createSupportedTransformationRequest( transformationRequest, - /* hasOutputFormatRotation= */ flipOrientation, + /* hasOutputFormatRotation= */ outputRotationDegrees != 0, requestedEncoderFormat, encoderSupportedFormat, supportedFallbackHdrMode));