#4304 - Adjustments after code review

This commit is contained in:
Arnold Szabo 2018-07-27 13:41:02 +03:00
parent 1f12f22bb5
commit dbd25d5854
2 changed files with 6 additions and 6 deletions

View File

@ -666,13 +666,13 @@ public class PlayerView extends FrameLayout {
* Sets whether a buffering spinner is displayed when the player is in the buffering state. The * Sets whether a buffering spinner is displayed when the player is in the buffering state. The
* buffering spinner is not displayed by default. * buffering spinner is not displayed by default.
* *
* Deprecated, use {@link #setShowBuffering(int)} * @deprecated Use {@link #setShowBuffering(int)}
* *
* @param showBuffering Whether the buffering icon is displayed * @param showBuffering Whether the buffering icon is displayed
*/ */
@Deprecated @Deprecated
public void setShowBuffering(boolean showBuffering) { public void setShowBuffering(boolean showBuffering) {
setShowBuffering(showBuffering ? SHOW_BUFFERING_ALWAYS : SHOW_BUFFERING_NEVER); setShowBuffering(showBuffering ? SHOW_BUFFERING_WHEN_PLAYING : SHOW_BUFFERING_NEVER);
} }
/** /**
@ -683,7 +683,7 @@ public class PlayerView extends FrameLayout {
* <li>{@link #SHOW_BUFFERING_ALWAYS} displayed always when buffering * <li>{@link #SHOW_BUFFERING_ALWAYS} displayed always when buffering
* <li>{@link #SHOW_BUFFERING_NEVER} not displayed at all * <li>{@link #SHOW_BUFFERING_NEVER} not displayed at all
* <li>{@link #SHOW_BUFFERING_WHEN_PLAYING} displayed only when playing and buffering * <li>{@link #SHOW_BUFFERING_WHEN_PLAYING} displayed only when playing and buffering
* </p></ul> * </ul></p>
* *
* @param showBuffering Buffering strategy that defines when the buffering icon is displayed * @param showBuffering Buffering strategy that defines when the buffering icon is displayed
*/ */

View File

@ -52,9 +52,9 @@
<attr name="hide_during_ads" format="boolean"/> <attr name="hide_during_ads" format="boolean"/>
<attr name="auto_show" format="boolean"/> <attr name="auto_show" format="boolean"/>
<attr name="show_buffering" format="enum"> <attr name="show_buffering" format="enum">
<enum name="show_buffering_never" value="0"/> <enum name="never" value="0"/>
<enum name="show_buffering_always" value="1"/> <enum name="always" value="1"/>
<enum name="show_buffering_when_playing" value="2"/> <enum name="when_playing" value="2"/>
</attr> </attr>
<attr name="keep_content_on_player_reset" format="boolean"/> <attr name="keep_content_on_player_reset" format="boolean"/>
<attr name="resize_mode"/> <attr name="resize_mode"/>