loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Post initial media button preferences update

Browse Source 
Controller and browsers are typically obtained with
Futures.addCallback(future, getMainExecutor()), which triggers
the onSuccess callback with a message post. We currently send
the initial media button preferences inline, causing the callback
in MediaController.Listener.onMediaButtonPreferencesChanged to
arrive before the FutureCallback.onSuccess callback.

In the test controller app, which causes crashed when
connecting to existing sessions for example. We can make this
more robust by also posting the initial update of the media button
preferences.

PiperOrigin-RevId: 726923498
This commit is contained in:
tonihei 2025-02-14 07:37:52 -08:00 committed by Copybara-Service
parent 28bfb27fb5
commit d5df227b3a
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
libraries/session/src/main/java/androidx/media3/session/MediaControllerImplLegacy.java
View File

@ -1647,16 +1647,20 @@ import org.checkerframework.checker.initialization.qual.UnderInitialization;
if (!oldControllerInfo.mediaButtonPreferences.equals( if (!oldControllerInfo.mediaButtonPreferences.equals(
newControllerInfo.mediaButtonPreferences)) { newControllerInfo.mediaButtonPreferences)) {
getInstance() getInstance()
.notifyControllerListener( .applicationHandler
listener -> { .post(
ignoreFuture( () ->
listener.onSetCustomLayout( getInstance()
getInstance(), newControllerInfo.mediaButtonPreferences)); .notifyControllerListener(
listener.onCustomLayoutChanged( listener -> {
getInstance(), newControllerInfo.mediaButtonPreferences); ignoreFuture(
listener.onMediaButtonPreferencesChanged( listener.onSetCustomLayout(
getInstance(), newControllerInfo.mediaButtonPreferences); getInstance(), newControllerInfo.mediaButtonPreferences));
}); listener.onCustomLayoutChanged(
getInstance(), newControllerInfo.mediaButtonPreferences);
listener.onMediaButtonPreferencesChanged(
getInstance(), newControllerInfo.mediaButtonPreferences);
}));
} }
return; return;
} }