loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-05-13 02:29:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Transformer: Clarify setResolution javadoc.

Browse Source 
This class may be removed soon, but in the meantime clarify this method's
javadoc summary fragment to make it marginally clearer that this only affects
the "displayed" height instead of the "encoded" height.

PiperOrigin-RevId: 501582219
This commit is contained in:
huangdarwin 2023-01-12 17:10:22 +00:00 committed by Rohit Singh
parent 3c4b4729da
commit d300b37a55
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/transformer/src/main/java/androidx/media3/transformer/TransformationRequest.java
View File

@ -215,7 +215,7 @@ public final class TransformationRequest {
} }
/** /**
* Sets the output resolution using the output height. * Sets the output resolution using the output height of the displayed video.
* *
* <p>Output width of the displayed video will scale to preserve the video's aspect ratio after * <p>Output width of the displayed video will scale to preserve the video's aspect ratio after
* other transformations. * other transformations.
@ -226,6 +226,10 @@ public final class TransformationRequest {
* {@linkplain #setScale(float,float) scaling} or @linkplain #setRotationDegrees(float) * {@linkplain #setScale(float,float) scaling} or @linkplain #setRotationDegrees(float)
* rotation} are requested. * rotation} are requested.
* *
* <p>Note that the output encoded video's dimensions may be swapped from the displayed video's
* dimensions, if the displayed video's height > width. This is to improve compatibility among
* different device encoders.
*
* @param outputHeight The output height of the displayed video, in pixels. * @param outputHeight The output height of the displayed video, in pixels.
* @return This builder. * @return This builder.
*/ */