loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-05-14 02:59:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

HDR: Remove comment explaining force sdr behavior with assetloaders.

Browse Source 
Before, if the upstream AssetLoader provides HDR to the VideoSamplePipeline when
HDR_MODE_EXPERIMENTAL_FORCE_INTERPRET_HDR_AS_SDR is requested, the
VideoSamplePipeline would attempt to tell the AssetLoader to output SDR, which
could be accomplished via MediaCodec tone-mapping in the AssetLoader.

However, this makes an assumption of the AssetLoader implementation, and
AssetLoaders may not all implement support for decoder tone-mapping. Remove javadoc
attempting to explain how AssetLoaders (ex. custom ones) could behave.

PiperOrigin-RevId: 510956820
This commit is contained in:
huangdarwin 2023-02-20 11:47:37 +00:00 committed by tonihei
parent 4a7326a286
commit d1df8e21d2
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libraries/transformer/src/main/java/androidx/media3/transformer/Transformer.java
View File

@ -138,14 +138,6 @@ public final class Transformer {
* Listener#onFallbackApplied(Composition, TransformationRequest, TransformationRequest)} will * Listener#onFallbackApplied(Composition, TransformationRequest, TransformationRequest)} will
* be invoked with the actual applied values. * be invoked with the actual applied values.
* *
* <p>If {@link TransformationRequest#hdrMode} is set to {@link
* TransformationRequest#HDR_MODE_EXPERIMENTAL_FORCE_INTERPRET_HDR_AS_SDR} and an {@link
* #setAssetLoaderFactory AssetLoader.Factory} is set, {@link TransformationRequest#hdrMode}
* will be ignored. In this case, if the {@link AssetLoader.Factory} passed produces HDR data,
* it will be automatically {@linkplain
* TransformationRequest#HDR_MODE_TONE_MAP_HDR_TO_SDR_USING_MEDIACODEC tone mapped to SDR using
* MediaCodec}.
*
* @param transformationRequest The {@link TransformationRequest}. * @param transformationRequest The {@link TransformationRequest}.
* @return This builder. * @return This builder.
*/ */