From d1df8e21d27dd0f003388c7ae16c485fd8290275 Mon Sep 17 00:00:00 2001 From: huangdarwin Date: Mon, 20 Feb 2023 11:47:37 +0000 Subject: [PATCH] HDR: Remove comment explaining force sdr behavior with assetloaders. Before, if the upstream AssetLoader provides HDR to the VideoSamplePipeline when HDR_MODE_EXPERIMENTAL_FORCE_INTERPRET_HDR_AS_SDR is requested, the VideoSamplePipeline would attempt to tell the AssetLoader to output SDR, which could be accomplished via MediaCodec tone-mapping in the AssetLoader. However, this makes an assumption of the AssetLoader implementation, and AssetLoaders may not all implement support for decoder tone-mapping. Remove javadoc attempting to explain how AssetLoaders (ex. custom ones) could behave. PiperOrigin-RevId: 510956820 --- .../java/androidx/media3/transformer/Transformer.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/Transformer.java b/libraries/transformer/src/main/java/androidx/media3/transformer/Transformer.java index c8a31787ae..dbdc033b9d 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/Transformer.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/Transformer.java @@ -138,14 +138,6 @@ public final class Transformer { * Listener#onFallbackApplied(Composition, TransformationRequest, TransformationRequest)} will * be invoked with the actual applied values. * - *

If {@link TransformationRequest#hdrMode} is set to {@link - * TransformationRequest#HDR_MODE_EXPERIMENTAL_FORCE_INTERPRET_HDR_AS_SDR} and an {@link - * #setAssetLoaderFactory AssetLoader.Factory} is set, {@link TransformationRequest#hdrMode} - * will be ignored. In this case, if the {@link AssetLoader.Factory} passed produces HDR data, - * it will be automatically {@linkplain - * TransformationRequest#HDR_MODE_TONE_MAP_HDR_TO_SDR_USING_MEDIACODEC tone mapped to SDR using - * MediaCodec}. - * * @param transformationRequest The {@link TransformationRequest}. * @return This builder. */