From ce80fe5361dd6ead0a9f122809ce8fde74b353d1 Mon Sep 17 00:00:00 2001 From: ibaker Date: Mon, 29 Nov 2021 16:59:53 +0000 Subject: [PATCH] Rollback of https://github.com/google/ExoPlayer/commit/f790d105b76cb92ac31cf0ab6c9557a41b4bc15b *** Original commit *** Remove usage of @ForOverride. Fixes the gradle compilation failures. Gradle dependencies need revising if we want to be using this, as checkerframework is ahead of their latest version, such that we can't compile. *** PiperOrigin-RevId: 412901827 --- library/transformer/build.gradle | 1 + .../android/exoplayer2/transformer/TransformerBaseRenderer.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/library/transformer/build.gradle b/library/transformer/build.gradle index a06a70a320..a89617a0b4 100644 --- a/library/transformer/build.gradle +++ b/library/transformer/build.gradle @@ -38,6 +38,7 @@ android { dependencies { implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion implementation project(modulePrefix + 'library-core') + compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion compileOnly 'org.checkerframework:checker-compat-qual:' + checkerframeworkCompatVersion compileOnly 'org.jetbrains.kotlin:kotlin-annotations-jvm:' + kotlinAnnotationsVersion diff --git a/library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerBaseRenderer.java b/library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerBaseRenderer.java index bf064520b2..4b78c64b8b 100644 --- a/library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerBaseRenderer.java +++ b/library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerBaseRenderer.java @@ -29,6 +29,7 @@ import com.google.android.exoplayer2.decoder.DecoderInputBuffer; import com.google.android.exoplayer2.source.SampleStream.ReadDataResult; import com.google.android.exoplayer2.util.MediaClock; import com.google.android.exoplayer2.util.MimeTypes; +import com.google.errorprone.annotations.ForOverride; import org.checkerframework.checker.nullness.qual.EnsuresNonNullIf; import org.checkerframework.checker.nullness.qual.MonotonicNonNull; import org.checkerframework.checker.nullness.qual.RequiresNonNull; @@ -133,6 +134,7 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull; muxerWrapperTrackEnded = false; } + @ForOverride @EnsuresNonNullIf(expression = "samplePipeline", result = true) protected abstract boolean ensureConfigured() throws ExoPlaybackException;