loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Enable lint errors in extractor tests

Browse Source 
Fix existing violations.

PiperOrigin-RevId: 702366292
This commit is contained in:
ibaker 2024-12-03 09:25:59 -08:00 committed by Copybara-Service
parent 876abe315b
commit c870fb7594
5 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libraries/extractor/build.gradle
View File

@ -27,11 +27,6 @@ android {
test.assets.srcDir '../test_data/src/test/assets/'
}
lintOptions {
// TODO: b/353490583 - Enable this once the violations are fixed.
checkTestSources false
}
publishing {
singleVariant('release') {
withSourcesJar()

2
libraries/extractor/src/androidTest/java/androidx/media3/extractor/text/CueSerializationTest.java
View File

@ -35,6 +35,7 @@ import androidx.media3.test.utils.TestUtil;
import androidx.media3.test.utils.truth.SpannedSubject;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import androidx.test.filters.SdkSuppress;
import com.google.common.collect.ImmutableList;
import org.junit.Test;
import org.junit.runner.RunWith;
@ -97,6 +98,7 @@ public class CueSerializationTest {
}
@Test
@SdkSuppress(minSdkVersion = 26)
public void serializingBitmapCue() throws Exception {
CueEncoder encoder = new CueEncoder();
CueDecoder decoder = new CueDecoder();

2
libraries/extractor/src/test/java/androidx/media3/extractor/mkv/MatroskaExtractorTest.java
View File

@ -15,7 +15,7 @@
*/
package androidx.media3.extractor.mkv;
import static androidx.media3.extractor.mp4.FragmentedMp4Extractor.FLAG_EMIT_RAW_SUBTITLE_DATA;
import static androidx.media3.extractor.mkv.MatroskaExtractor.FLAG_EMIT_RAW_SUBTITLE_DATA;
import androidx.media3.extractor.text.DefaultSubtitleParserFactory;
import androidx.media3.extractor.text.SubtitleParser;

3
libraries/extractor/src/test/java/androidx/media3/extractor/ogg/OggExtractorNonParameterizedTest.java
View File

@ -19,6 +19,7 @@ import static androidx.media3.test.utils.TestUtil.getByteArray;
import static com.google.common.truth.Truth.assertThat;
import androidx.media3.common.C;
import androidx.media3.extractor.Extractor;
import androidx.media3.extractor.PositionHolder;
import androidx.media3.test.utils.ExtractorAsserts;
import androidx.media3.test.utils.FakeExtractorInput;
@ -46,7 +47,7 @@ public final class OggExtractorNonParameterizedTest {
OggExtractor oggExtractor = new OggExtractor();
oggExtractor.init(new FakeExtractorOutput());
// We feed data to the extractor until the end of input is reached.
while (oggExtractor.read(input, new PositionHolder()) != C.RESULT_END_OF_INPUT) {}
while (oggExtractor.read(input, new PositionHolder()) != Extractor.RESULT_END_OF_INPUT) {}
// We call read again to check that it does not throw an IllegalStateException.
assertThat(oggExtractor.read(input, new PositionHolder())).isEqualTo(C.RESULT_END_OF_INPUT);
}

2
libraries/extractor/src/test/java/androidx/media3/extractor/ts/TsExtractorTest.java
View File

@ -15,10 +15,10 @@
*/
package androidx.media3.extractor.ts;
import static androidx.media3.extractor.mp4.FragmentedMp4Extractor.FLAG_EMIT_RAW_SUBTITLE_DATA;
import static androidx.media3.extractor.ts.DefaultTsPayloadReaderFactory.FLAG_DETECT_ACCESS_UNITS;
import static androidx.media3.extractor.ts.DefaultTsPayloadReaderFactory.FLAG_ENABLE_HDMV_DTS_AUDIO_STREAMS;
import static androidx.media3.extractor.ts.TsExtractor.DEFAULT_TIMESTAMP_SEARCH_BYTES;
import static androidx.media3.extractor.ts.TsExtractor.FLAG_EMIT_RAW_SUBTITLE_DATA;
import static androidx.media3.extractor.ts.TsExtractor.MODE_MULTI_PMT;
import static androidx.media3.extractor.ts.TsExtractor.MODE_SINGLE_PMT;
import static com.google.common.truth.Truth.assertThat;