diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/DynamicConcatenatingMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/DynamicConcatenatingMediaSource.java index ad2e154f6d..79f7d8dd48 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/DynamicConcatenatingMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/DynamicConcatenatingMediaSource.java @@ -186,8 +186,8 @@ public final class DynamicConcatenatingMediaSource implements MediaSource, ExoPl @Override public void maybeThrowSourceInfoRefreshError() throws IOException { - for (MediaSourceHolder mediaSourceHolder : mediaSourceHolders) { - mediaSourceHolder.mediaSource.maybeThrowSourceInfoRefreshError(); + for (int i = 0; i < mediaSourceHolders.size(); i++) { + mediaSourceHolders.get(i).mediaSource.maybeThrowSourceInfoRefreshError(); } } @@ -221,8 +221,8 @@ public final class DynamicConcatenatingMediaSource implements MediaSource, ExoPl @Override public void releaseSource() { - for (MediaSourceHolder mediaSourceHolder : mediaSourceHolders) { - mediaSourceHolder.mediaSource.releaseSource(); + for (int i = 0; i < mediaSourceHolders.size(); i++) { + mediaSourceHolders.get(i).mediaSource.releaseSource(); } } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CachedContentIndex.java b/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CachedContentIndex.java index 58cc70d68d..10bc298579 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CachedContentIndex.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CachedContentIndex.java @@ -34,9 +34,9 @@ import java.io.OutputStream; import java.security.InvalidAlgorithmParameterException; import java.security.InvalidKeyException; import java.security.NoSuchAlgorithmException; +import java.util.ArrayList; import java.util.Collection; import java.util.HashMap; -import java.util.LinkedList; import java.util.Random; import java.util.Set; import javax.crypto.Cipher; @@ -176,14 +176,14 @@ import javax.crypto.spec.SecretKeySpec; /** Removes empty {@link CachedContent} instances from index. */ public void removeEmpty() { - LinkedList cachedContentToBeRemoved = new LinkedList<>(); + ArrayList cachedContentToBeRemoved = new ArrayList<>(); for (CachedContent cachedContent : keyToContent.values()) { if (cachedContent.isEmpty()) { cachedContentToBeRemoved.add(cachedContent.key); } } - for (String key : cachedContentToBeRemoved) { - removeEmpty(key); + for (int i = 0; i < cachedContentToBeRemoved.size(); i++) { + removeEmpty(cachedContentToBeRemoved.get(i)); } } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/SimpleCache.java b/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/SimpleCache.java index 2da6ba759b..62bd2783b8 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/SimpleCache.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/SimpleCache.java @@ -22,7 +22,6 @@ import java.io.File; import java.util.ArrayList; import java.util.HashMap; import java.util.HashSet; -import java.util.LinkedList; import java.util.NavigableSet; import java.util.Set; import java.util.TreeSet; @@ -308,7 +307,7 @@ public final class SimpleCache implements Cache { * no longer exist. */ private void removeStaleSpansAndCachedContents() throws CacheException { - LinkedList spansToBeRemoved = new LinkedList<>(); + ArrayList spansToBeRemoved = new ArrayList<>(); for (CachedContent cachedContent : index.getAll()) { for (CacheSpan span : cachedContent.getSpans()) { if (!span.file.exists()) { @@ -316,9 +315,9 @@ public final class SimpleCache implements Cache { } } } - for (CacheSpan span : spansToBeRemoved) { + for (int i = 0; i < spansToBeRemoved.size(); i++) { // Remove span but not CachedContent to prevent multiple index.store() calls. - removeSpan(span, false); + removeSpan(spansToBeRemoved.get(i), false); } index.removeEmpty(); index.store();