loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-29 22:36:54 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

MCVR.hasSurfaceForCodec considers VideoSink

Browse Source 
This change keeps getSurfaceForCodec and hasSurfaceForCodec in sync.
Before this change when ExoPlayer is configured with setVideoEffects
and no display surface, codecs that need Set Output Surface Workaround
would not be initialized because hasSurfaceForCodec always returns false

PiperOrigin-RevId: 692900899
This commit is contained in:
dancho 2024-11-04 03:14:56 -08:00 committed by Copybara-Service
parent aebda58314
commit bd90ef38b0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/MediaCodecVideoRenderer.java
View File

@ -1815,7 +1815,8 @@ public class MediaCodecVideoRenderer extends MediaCodecRenderer
}
private boolean hasSurfaceForCodec(MediaCodecInfo codecInfo) {
return (displaySurface != null && displaySurface.isValid())
return videoSink != null
|| (displaySurface != null && displaySurface.isValid())
|| shouldUseDetachedSurface(codecInfo)
|| shouldUsePlaceholderSurface(codecInfo);
}